Allow usage of ratchet/rfc6455 0.4+ #1112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratchet/rfc6455 as a new required param in the constructor of ServerNegotiator which is breaking the code. As this project still supports very old php versions we need to keep support for 0.3 but also include support for 0.4. Reflection is used to check for the correct version. The option of using composer's new version checks is not possible as the older versions of composer do not have this class.
jaapio
force-pushed
the
fix/RFC6455-04
branch
from
220b8dc to
d5e8555
Compare
Contributor
Author
|
@clue done, thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ratchet/rfc6455 as a new required param in the constructor of ServerNegotiator which is breaking the code. As this project still supports very old php versions we need to keep support for 0.3 but also include support for 0.4. Reflection is used to check for the correct version.
The option of using composer's new version checks is not possible as the older versions of composer do not have this class.