Full support for PHP 8.1 and PHP 8.0 #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRotmann
approved these changes
May 15, 2025
Contributor
PaulRotmann
left a comment
PaulRotmann
left a comment
There was a problem hiding this comment.
Nice, keep it going!
Member
Author
|
We're getting there! Let's get this shipped |
This was referenced May 15, 2025
This was referenced Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds full support for PHP 8.1 and PHP 8.0. This is part 5 of reviving Ratchet as discussed in #1054, unblocking more future progress.
With these changes applied, the existing test suite recently updated with #1092 and #1093 now works fine on PHP 8.1 and PHP 8.0 at least. Once merged, I'll use this as a starting point to add newer PHP 8.2+ version support as discussed in #1003 and elsewhere.
Note that this temporarily pins symfony/http-foundation to < 6 for the tests only. The session storage methods are currently incompatible with HttpFoundation 6+ and #926 really shouldn't have been merged without more tests, see #969 for details. This is something I would like to address in a separate follow-up, as this shouldn't limit our ability to test PHP 8+ for the time being.
Overall, this still requires a massive effort. If you want to support this project, please consider sponsoring @reactphp ❤️
Builds on top of #1093, #1092, #1091 and #1088, one step closer to reviving Ratchet as discussed in #1054