Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore startup message; Add unit tests; Reduce code complexity #117

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Restore startup message; Add unit tests; Reduce code complexity #117

wants to merge 11 commits into from

Conversation

jaller94
Copy link
Collaborator

@jaller94 jaller94 commented May 1, 2022 •
edited
Loading

First, merge #115.

  • Fixed: Brings back the startup message "Welcome to MapSCII! Use your cursors to navigate, a/z to zoom, q to quit."
  • Change: The footer now shows numbers with a fixed amount of digits after the point
  • Added: Most basic unit tests for more classes
  • Refactor: Reduces code complexity

@jaller94 jaller94 changed the title Reduce code complexity Hide "Unimplemented type: 4" error; Restore startup message; Add unit tests; Reduce code complexity May 1, 2022
@rastapasta
Copy link
Owner

Aloha @jaller94 - thanks for your PR, just... I'm kind of against 'hiding the error' instead of fixing it :)

@jaller94 jaller94 changed the title Hide "Unimplemented type: 4" error; Restore startup message; Add unit tests; Reduce code complexity Restore startup message; Add unit tests; Reduce code complexity Feb 26, 2023
@jaller94 jaller94 mentioned this pull request Feb 26, 2023
Open
@jaller94 jaller94 mentioned this pull request Feb 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaller94 @rastapasta