RaspiStill: Read sensor information correctly if one of each type is … #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attached. On a CM with one OV5647 and one IMX219, the setup of whichever sensor is camera 0 was taken for both sensors. That meant the default resolution and EXIF headers were wrong for the second camera.
|
Ping @JamesH65 for review. |
|
Looks fine to me. |
|
@popcornmix Do you want to review, or shall I merge? |
|
Looks fine. Feel free to merge. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 8, 2017
firmware: FXL6408 expander: allow readback of output state firmware: IL Video_splitter: Handle stereoscopic into buffers See: waveform80/picamera#342 firmware: IL Image_encode: Correct list of supported formats See: #733 bootcode: BOOTROM is bit position not a maskable value. BOOTROM_RELEASE_BCM2837_B0_RC3 bootcode: Add USB device boot as standard boot mode bootcode: Support Pi 1 model B for MSD booting firmware: i2c_gpio: Disable logging firmware: Camplus annotate: hold back lines until annotated See: #701 userland: Add pkg-config file for mmal See: raspberrypi/userland#374 userland: RaspiStill: Read sensor information correctly if one of each type is attached See: raspberrypi/userland#373
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Feb 8, 2017
firmware: FXL6408 expander: allow readback of output state firmware: IL Video_splitter: Handle stereoscopic into buffers See: waveform80/picamera#342 firmware: IL Image_encode: Correct list of supported formats See: raspberrypi/firmware#733 bootcode: BOOTROM is bit position not a maskable value. BOOTROM_RELEASE_BCM2837_B0_RC3 bootcode: Add USB device boot as standard boot mode bootcode: Support Pi 1 model B for MSD booting firmware: i2c_gpio: Disable logging firmware: Camplus annotate: hold back lines until annotated See: raspberrypi/firmware#701 userland: Add pkg-config file for mmal See: raspberrypi/userland#374 userland: RaspiStill: Read sensor information correctly if one of each type is attached See: raspberrypi/userland#373
neuschaefer
pushed a commit
to neuschaefer/raspi-binary-firmware
that referenced
this pull request
Feb 27, 2017
firmware: FXL6408 expander: allow readback of output state firmware: IL Video_splitter: Handle stereoscopic into buffers See: waveform80/picamera#342 firmware: IL Image_encode: Correct list of supported formats See: raspberrypi#733 bootcode: BOOTROM is bit position not a maskable value. BOOTROM_RELEASE_BCM2837_B0_RC3 bootcode: Add USB device boot as standard boot mode bootcode: Support Pi 1 model B for MSD booting firmware: i2c_gpio: Disable logging firmware: Camplus annotate: hold back lines until annotated See: raspberrypi#701 userland: Add pkg-config file for mmal See: raspberrypi/userland#374 userland: RaspiStill: Read sensor information correctly if one of each type is attached See: raspberrypi/userland#373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…attached.
On a CM with one OV5647 and one IMX219, the setup of whichever sensor
is camera 0 was taken for both sensors. That meant the default resolution
and EXIF headers were wrong for the second camera.