Skip to content

Conversation

@alinsalaru
Copy link

@alinsalaru alinsalaru commented Sep 1, 2025

…after a period of time

The Problem:

  • When loading saved SSH keys from settings, appending occurred to the
    existing model without clearing it first
  • Each time you saved settings, the keys would get duplicated exponentially: 1 → 2 →
    4 → 8 → 16 → ...

This means that every time the dialog opens, it appends the saved keys to whatever keys are already in the model, possible culprit to bloating performance to whole app.

Related with: #1160

…after a period of time

This means that every time the dialog opens, it appends the saved keys to whatever keys are already in the model, bloating the whole app.
@alinsalaru
Copy link
Author

@tdewey-rpi really appreciate the work you've done for this project!
Can you please look at into this? it's a small change but offers a good performance improvement.

All the best in the world!

@lurch
Copy link
Contributor

lurch commented Oct 16, 2025

The qml branch corresponds to the 1.9.x releases of RPi Imager, but I believe that active-development of Imager has now switched to the main branch (for the upcoming 2.0.x releases).

@alinsalaru
Copy link
Author

Indeed, my mistake, will follow on main branch.
And close this, thank you @lurch

@alinsalaru alinsalaru closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants