Fix FindLIBUSB.cmake for Windows and FreeBSD builds #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on a modified version of the suggestions in https://www.raspberrypi.org/forums/viewtopic.php?p=1854531
lurch
changed the title
lurch
commented
May 15, 2021
Comment on lines
+24
to
26
| FIND_LIBRARY(LIBUSB_LIBRARIES NAMES usb usb-1.0 libusb-1.0 | ||
| HINTS $ENV{LIBUSB_ROOT}/VS2019/MS32/static | ||
| PATHS ${PC_LIBUSB_LIBDIR} ${PC_LIBUSB_LIBRARY_DIRS}) |
There was a problem hiding this comment.
@kilograham Looking at https://cmake.org/cmake/help/latest/command/find_library.html have I actually got HINTS and PATHS the wrong way around?
i.e. does the usage of ${PC_LIBUSB_LIBDIR} count as "computed by system introspection" meaning that it ought to use the HINTS option; and does the usage of $ENV{LIBUSB_ROOT} count as a "hard-coded guess" meaning that it ought to use the PATHS option?
|
fixed via other PR |
Fixed via 757f2ae 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a modified version of the suggestions in https://www.raspberrypi.org/forums/viewtopic.php?p=1854531
EDIT: And #29