Skip to content

Add missing cast to uint32_t in hw_divider_u32_quotient for host #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kilograham merged 1 commit into from
May 23, 2021
Merged

Add missing cast to uint32_t in hw_divider_u32_quotient for host #436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/host/hardware_divider/include/hardware/divider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ static inline int32_t hw_divider_s32_remainder_wait() {
}

static inline uint32_t hw_divider_u32_quotient(uint32_t a, uint32_t b) {
return b ? (a / b) : -1;
return b ? (a / b) : (uint32_t)(-1);
Copy link
Contributor

@kilograham kilograham May 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to merge anyway, but stylistically I would do (uint32_t)-1

}

static inline uint32_t hw_divider_u32_remainder(uint32_t a, uint32_t b) {
Expand Down