Refactor extraction-scripts to reduce code-duplication#2592
Merged
kilograham merged 1 commit intodevelopfrom Jul 25, 2025
Merged
Refactor extraction-scripts to reduce code-duplication#2592kilograham merged 1 commit intodevelopfrom
kilograham merged 1 commit intodevelopfrom
Conversation
extract_configs.py now supports reading min, max or default values from a #define value (which reduces false-positives)
kilograham
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_configs.py now supports reading min, max or default values from a #define value (which reduces false-positives)
This means for an entry like:
the
tools/exract_configs.pyscript is now able to (internally) resolve thedefaultvalue to32(becausesrc/rp2040/hardware_regs/include/hardware/platform_defs.hsays#define NUM_IRQS _u(32)), and so you no longer get a warning like:(the contents of the TSV files that get created are unchanged though)