Throw a warning when using the example signing/encryption keys#2352
Merged
kilograham merged 3 commits intoraspberrypi:developfrom Mar 22, 2025
Merged
Throw a warning when using the example signing/encryption keys#2352kilograham merged 3 commits intoraspberrypi:developfrom
kilograham merged 3 commits intoraspberrypi:developfrom
Conversation
This is automatically disabled for pico-examples, and can be manually disabled by setting PICO_ALLOW_EXAMPLE_KEYS
lurch
reviewed
Mar 17, 2025
lurch
reviewed
Mar 17, 2025
| RESULT_VARIABLE compare_result | ||
| ) | ||
| if(compare_result EQUAL 0) | ||
| message(WARNING "${TARGET} is using a default ${TYPE} key - this must be changed before production") |
Contributor
There was a problem hiding this comment.
Would there be any value in also having a PICO_FORBID_EXAMPLE_KEYS setting, which changes this WARNING to an ERROR ? 🤷
lurch
reviewed
Mar 17, 2025
lurch
reviewed
Mar 17, 2025
tdewey-rpi
previously approved these changes
Mar 18, 2025
tdewey-rpi
left a comment
tdewey-rpi
left a comment
There was a problem hiding this comment.
Good use of CMake functionality, and I approve of the concept entirely.
Make doing the right thing easy, and the wrong thing hard.
kilograham
reviewed
Mar 22, 2025
kilograham
approved these changes
Mar 22, 2025
will-v-pi
added a commit
to raspberrypi/pico-examples
that referenced
this pull request
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This throws a CMake warning when the example signing/encryption keys from pico-examples are used to sign/encrypt a binary, as the user should replace these with their own keys when actually developing secure applications
This is automatically disabled for pico-examples (as that can use the example keys), and can be manually disabled by setting PICO_ALLOW_EXAMPLE_KEYS