Fix pioasm generating an enum member which doesn't match pio.h#2324
Merged
kilograham merged 1 commit intoraspberrypi:developfrom Mar 18, 2025
Merged
Fix pioasm generating an enum member which doesn't match pio.h#2324kilograham merged 1 commit intoraspberrypi:developfrom
kilograham merged 1 commit intoraspberrypi:developfrom
Conversation
The enum pio_mov_status_type expects the member name to be STATUS_IRQ_SET.
kilograham
approved these changes
Mar 18, 2025
Contributor
|
oops; thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When including the
.mov_statusdirective to configure STATUS based on an IRQ flag (ex:.mov_status irq set 0), pioasm generates code with a reference to "STATUS_IRQ_INDEX", but this is different from the member name as defined in pio.h.This generated the following code:
And thus caused the compile error:
This fix changes the generated name so it matches the enum.