Conversation
…e with a size of zero is not a legal SVD, so including something hopefully harmless
…competing #defines as these were called USER_IRQs in the SDK 1.x
Contributor
Author
|
Note, i have not added the extra IRQs to the RP2040 SVD as i don't know if that is rocking the boat too much (as i'd have to change the |
Contributor
Author
|
cc @jonathanpallant, @pta2002, @jannic not sure if i want to risk making this change at the last hour for 2.1.1 - LMK... if i don't see lots of happy faces, I'll push it to 2.1.2 |
lurch
reviewed
Feb 15, 2025
Contributor
Author
|
pushing to 2.2.0 since still no feedback |
|
Looks ok to me |
…s backwards incompatible, but unlikely used
lurch
previously approved these changes
Mar 24, 2025
Contributor
lurch
left a comment
lurch
left a comment
There was a problem hiding this comment.
I've not tested this, but it all looks sensible.
lurch
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1898