convert windows path delimiter to posix (#2149)#2150
Merged
kilograham merged 2 commits intoraspberrypi:developfrom Jan 7, 2025
Merged
convert windows path delimiter to posix (#2149)#2150kilograham merged 2 commits intoraspberrypi:developfrom
kilograham merged 2 commits intoraspberrypi:developfrom
Conversation
Contributor
lurch
reviewed
Dec 28, 2024
ndabas
reviewed
Dec 28, 2024
Contributor
ndabas
left a comment
ndabas
left a comment
There was a problem hiding this comment.
The overall fix looks good to me.
Contributor
Author
|
added explicite posix conversion result variable 3a7f95d |
jjonethal
commented
Dec 30, 2024
Contributor
Author
jjonethal
left a comment
jjonethal
left a comment
There was a problem hiding this comment.
intermediate posix path conversion result stored in file_path_posix.
jjonethal
commented
Dec 30, 2024
Contributor
|
LGTM, but I (currently) don't have access to a Windows PC with which to test this. |
peterharperuk
approved these changes
Jan 2, 2025
Contributor
|
Seems to work ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2149
When generating lwip file system data convert windows directory separators by posix separators.
This is an issue when native directory during resource generation separator is "\" as on windows. Running toolchain from mingw64 python3 would also preserve "\" in resource name which would cause mismatch on resource lookup.
Fix should be portable with python 3.4 and up.