Added some Waveshare board support#2145
Conversation
|
@waveshare Apologies for the delay in getting round to reviewing this. However if I compare the but the version in #2174 says: and https://www.waveshare.com/wiki/RP2350-One#Pinout_Definition also says that there's a WS2812 connected to but your pinout diagram seems to show that GP16 isn't available on any of the user-accessible pins? |
|
Sorry, this is our mistake, #2174 is right, we will fix it soon |
4ad6a03 to
6224c6f
Compare
|
Hello, |
|
Thanks for the updates, my However I see that in various different files you've defined: (along with the associated pin-defines for each of those SPI interfaces). Similarly, perhaps it would make sense for both to be named just These suggestions are entirely optional; if you disagree I'm happy to approve this PR as-is. |
|
I think your suggestion is very good. Give me some time and I will solve it. |
|
Please take a look. |
Signed-off-by: eng33 <eng33@waveshare.com>
lurch
left a comment
There was a problem hiding this comment.
Fantastic 👍
Thank you for taking my comments into account, and thank you so much for adding all these board headers! ❤️
Signed-off-by: eng33 <eng33@waveshare.com> Co-authored-by: eng33 <eng33@waveshare.com>
Added some weveshare board support,PTAL.