Add rom_data_lookup_inline function#2116
Merged
kilograham merged 2 commits intoraspberrypi:developfrom Dec 2, 2024
Merged
Conversation
Allows ROM data lookup from FLASH/RAM sensitive code
Fixes bug introduced by raspberrypi#2082 where flash_devinfo_get_cs_size would use rom_data_lookup from flash during a __no_inline_not_in_flash_func
kilograham
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
rom_data_lookup_inlinefunction instead ofrom_data_lookup, similar torom_func_lookup_inline. The code is moved frombootrom.ctobootrom.h, with therom_data_lookupfunction changed to a simple call ofrom_data_lookup_inline, similar torom_func_lookup.Also use this inline lookup in
flash_devinfo_ptrto avoid touching a function in flash during flash programming.