Release the lock in mbedtls_sha256_free if it was not released already#2105
Merged
kilograham merged 3 commits intoraspberrypi:developfrom Jan 31, 2025
Merged
Release the lock in mbedtls_sha256_free if it was not released already#2105kilograham merged 3 commits intoraspberrypi:developfrom
kilograham merged 3 commits intoraspberrypi:developfrom
Conversation
…y. Requires making pico_sha256_unlock include-able. Fixes raspberrypi#2103.
kilograham
requested changes
Nov 27, 2024
Contributor
kilograham
left a comment
kilograham
left a comment
There was a problem hiding this comment.
I think i'd prefer to expose something like
void pico_sha256_cleanup(pico_sha256_state_t *state, sha256_result_t *out) {
if (state->locked) {
pico_sha256_unlock(state);
}
}
peterharperuk
previously approved these changes
Jan 22, 2025
Contributor
|
I wrote a test for this. I'll push this if you want @kilograham |
kilograham
reviewed
Jan 22, 2025
kilograham
approved these changes
Jan 29, 2025
will-v-pi
pushed a commit
to will-v-pi/pico-sdk
that referenced
this pull request
Mar 20, 2025
raspberrypi#2105) * Release the lock in mbedtls_sha256_free if it was not released already. Requires making pico_sha256_unlock include-able. Fixes raspberrypi#2103. * addres lock release API comment * Fix description of pico_sha256_cleanup --------- Co-authored-by: nils <nils@nils> Co-authored-by: Peter Harper <peter.harper@raspberrypi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release the lock in
mbedtls_sha256_freeif it was not released already. Requires makingpico_sha256_unlockinclude-able. Fixes #2103.