Handle probe dependencies and hard errors better #6645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popcornmix
reviewed
Feb 3, 2025
| platform_set_drvdata(pdev, fw); | ||
| } else { | ||
| kfree(fw); | ||
| platform_set_drvdata(pdev, ERR_PTR(-ENOENT)); |
There was a problem hiding this comment.
We do dereference this in rp1_firmware_remove (without a check).
I'm not sure if that can happen, but looks like a potential pitfall.
There was a problem hiding this comment.
Testing the obvious fix has uncovered some deficiencies in the end-of-life code. Thank goodness for runtime overlays.
If the RP1 firmware has reported an error then return that from the PIO probe function, otherwise defer the probing. Link: raspberrypi#6642 Signed-off-by: Phil Elwell <[email protected]>
To avoid pointless retries, let the probe function succeed if the firmware interface is configured correctly but the firmware is incompatible. The value of the private drvdata field holds the outcome. Link: raspberrypi#6642 Signed-off-by: Phil Elwell <[email protected]>
The of_xlate method saves the calculated event mask in the con_priv field. It also rejects subsequent attempt to use that channel because the mask is non-zero, which causes a repeated instantiation of a client driver to fail. The of_xlate method is not meant to be a point of resource acquisition. Leave the con_priv initialisation, but drop the test that it was previously zero. Signed-off-by: Phil Elwell <[email protected]>
|
With the latest updates, the rp1 firmware driver and pio driver can be repeatedly instantiated and removed with no crashes or obvious leaks. |
popcornmix
approved these changes
Feb 4, 2025
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 4, 2025
See: raspberrypi/linux#6636 kernel: misc: rp1-pio: SM_CONFIG_XFER32 = larger DMA bufs See: raspberrypi/linux#6640 kernel: Handle probe dependencies and hard errors better See: raspberrypi/linux#6645 kernel: spi: dw: Wait for idle after TX See: raspberrypi/linux#6646 See: raspberrypi/linux#6649
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Feb 4, 2025
See: raspberrypi/linux#6636 kernel: misc: rp1-pio: SM_CONFIG_XFER32 = larger DMA bufs See: raspberrypi/linux#6640 kernel: Handle probe dependencies and hard errors better See: raspberrypi/linux#6645 kernel: spi: dw: Wait for idle after TX See: raspberrypi/linux#6646 See: raspberrypi/linux#6649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6642 is a report of intermittent failures for the PIO driver to contact the firmware. These failures can be traced to the failure of PIO driver to distinguish hard errors and transient failures. The commits in this PR fix the PIO driver in this regard, but also improve the firmware driver to avoid pointless retries in the event that the firmware is not compatible.