Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCI: brcmstb: Force setting gen #6486

Closed
wants to merge 1 commit into from

Conversation

ElDavoo
Copy link

@ElDavoo ElDavoo commented Nov 21, 2024

Without this forgotten code block, my NVMe SSD does not get detected on my Pi 5.
Please note I don't have other setups / testing equipment.

Closes #6484 .

Calling brcm_pcie_set_gen seems necessary to detect PCIe devices
on BCM2712 and probably others.

Signed-off-by: Davide Palma (ElDavo) <[email protected]>
@popcornmix
Copy link
Collaborator

The dev_info(pcie->dev, "Forcing gen %d\n", pcie->gen); should be dropped as the same message is output inside brcm_pcie_set_gen.

@P33M upstream has the call to brcm_pcie_set_gen in brcm_pcie_start_link (which is how we do it on 6.12 kernel).
Can you see why the upstream way does not work? Should that call to brcm_pcie_start_link be removed?

@P33M
Copy link
Contributor

P33M commented Nov 22, 2024

In our case we set the link gen in brcm_pcie_setup() prior to releasing fundamental reset; upstream does it after during brcm_pcie_start_link(). Either the core only samples the value in the link control register before linkup and not after, or if the drive is unreliable at gen3 then it's already broken by the time the limit is imposed.

@pelwell
Copy link
Contributor

pelwell commented Nov 22, 2024

Running sudo rpi-update pulls/6487 will install a trial build with @P33M's potential fix. Beta software, back up your data, etc.

@ElDavoo
Copy link
Author

ElDavoo commented Nov 22, 2024

Superseded by #6487 which fixes it much better

@ElDavoo ElDavoo closed this Nov 22, 2024
@popcornmix
Copy link
Collaborator

Thanks for the detective work of finding out what was going wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants