-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Raspberry Touch 2 rotation with overlay #6480
Conversation
Commits should include a commit text and |
@6by9 Did I get this right? Who should be listed as "Signed-off-by: "? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by:
is documented in https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
It should match the commit author in this case. For upstream both would need use your real name rather than any nickname, but for dtoverlays that isn't as critical.
The patches get applied to the tree exactly as they are presented in the PR. The 3 changes therefore want to get squashed into one, and force pushed ( |
I see. Lets close this PR and open another, correct one. - Do you agree? |
No - if the end result is one patch then we can squash at the point of merging. |
Thanks. In such case, is there anything else needed from me at this point? |
I think we're good - I'll just give it the once over then merge. |
See: #6480 Signed-off-by: foonerd <[email protected]>
See: #6480 Signed-off-by: foonerd <[email protected]>
The panel-ilitek-ili9881c.c which Touch Display 2 is based on already contains orientation.
By minor update to the vc4-kms-dsi-ili9881-7inch-overlay.dts panel can be rotated with minimal effort.
Issue opened here:
raspberrypi/documentation#3923
Complete discussion and working dbto in the community thread:
https://community.volumio.com/t/guide-official-raspberry-touch-display-2/69791