Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Raspberry Touch 2 rotation with overlay #6480

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

foonerd
Copy link
Contributor

@foonerd foonerd commented Nov 20, 2024

The panel-ilitek-ili9881c.c which Touch Display 2 is based on already contains orientation.
By minor update to the vc4-kms-dsi-ili9881-7inch-overlay.dts panel can be rotated with minimal effort.

Issue opened here:
raspberrypi/documentation#3923

Complete discussion and working dbto in the community thread:
https://community.volumio.com/t/guide-official-raspberry-touch-display-2/69791

@6by9
Copy link
Contributor

6by9 commented Nov 20, 2024

Commits should include a commit text and Signed-off-by: line., but otherwise looks reasonable.

@foonerd
Copy link
Contributor Author

foonerd commented Nov 20, 2024

@6by9
For my benefit, the commit line should be:
dtoverlays: Enable Raspberry Touch 2 rotation

Did I get this right?

Who should be listed as "Signed-off-by: "?

Copy link
Contributor

@6by9 6by9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: is documented in https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

It should match the commit author in this case. For upstream both would need use your real name rather than any nickname, but for dtoverlays that isn't as critical.

arch/arm/boot/dts/overlays/README Outdated Show resolved Hide resolved
@6by9
Copy link
Contributor

6by9 commented Nov 20, 2024

The patches get applied to the tree exactly as they are presented in the PR. The 3 changes therefore want to get squashed into one, and force pushed (git push -f ... ) to your Github branch.

@foonerd
Copy link
Contributor Author

foonerd commented Nov 20, 2024

I see. Lets close this PR and open another, correct one. - Do you agree?

@pelwell
Copy link
Contributor

pelwell commented Nov 20, 2024

No - if the end result is one patch then we can squash at the point of merging.

@foonerd
Copy link
Contributor Author

foonerd commented Nov 20, 2024

Thanks. In such case, is there anything else needed from me at this point?

@pelwell
Copy link
Contributor

pelwell commented Nov 20, 2024

I think we're good - I'll just give it the once over then merge.

@pelwell pelwell merged commit fa6ad4b into raspberrypi:rpi-6.6.y Nov 20, 2024
pelwell pushed a commit that referenced this pull request Nov 21, 2024
pelwell pushed a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants