staging/bcm2835-codec: Allow a different stride alignment per role #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deinterlace and decode aren't affected in the same way as encode and ISP by the alignment requirement on 3 plane YUV420. Decode would be affected, but it always aligns the height up to a macroblock, and uses the selection API to reflect that. Add in the facility to set the bytesperline alignment per role. Signed-off-by: Dave Stevenson <[email protected]>
6by9
force-pushed
the
rpi-5.10.y-codecs
branch
from
5b3aaae to
735f96e
Compare
|
Attempt 2 - NULL derefs don't work too well. |
|
Yes, this fixes my regression from "staging/bcm2835-codec: bytesperline for YUV420/YVU420 needs to be 64" |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Dec 1, 2021
kernel: drivers: bcm2835_unicam: Add logging message when a frame is dropped See: raspberrypi/linux#4748 kernel: staging/bcm2835-codec: Allow a different stride alignment per role See: raspberrypi/linux#4746 kernel: KMS fixes and ISP pitch fix See: raspberrypi/linux#4744 kernel: media: rpivid: remove min_buffers_needed from src queue See: raspberrypi/linux#4745 firmware: board_info: Add upstream dtb names for cm1 & 3 firmware: board_info: Add upstream dtb name for cm4 See: #1660 firmware: platform: Allow users to disable camera boot HMAC check See: #1657 firmware: clock: 2711: Fix potential API issue in 2711 VCO setup firmware: arm_loader: Enable USB MSD boot mode on Zero 2 W firmware: isp: Fix Rec.709 colour space problems userland: raspicam: Check system is running legacy camera stack See: raspberrypi/userland#713 userland: mmal: Hack to make mmal core register VideoCore components See: raspberrypi/userland#714
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Dec 1, 2021
kernel: drivers: bcm2835_unicam: Add logging message when a frame is dropped See: raspberrypi/linux#4748 kernel: staging/bcm2835-codec: Allow a different stride alignment per role See: raspberrypi/linux#4746 kernel: KMS fixes and ISP pitch fix See: raspberrypi/linux#4744 kernel: media: rpivid: remove min_buffers_needed from src queue See: raspberrypi/linux#4745 firmware: board_info: Add upstream dtb names for cm1 & 3 firmware: board_info: Add upstream dtb name for cm4 See: raspberrypi/firmware#1660 firmware: platform: Allow users to disable camera boot HMAC check See: raspberrypi/firmware#1657 firmware: clock: 2711: Fix potential API issue in 2711 VCO setup firmware: arm_loader: Enable USB MSD boot mode on Zero 2 W firmware: isp: Fix Rec.709 colour space problems userland: raspicam: Check system is running legacy camera stack See: raspberrypi/userland#713 userland: mmal: Hack to make mmal core register VideoCore components See: raspberrypi/userland#714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deinterlace and decode aren't affected in the same way as encode
and ISP by the alignment requirement on 3 plane YUV420.
Decode would be affected, but it always aligns the height up to
a macroblock, and uses the selection API to reflect that.
Add in the facility to set the bytesperline alignment per role.
Signed-off-by: Dave Stevenson [email protected]