Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS fixes and ISP pitch fix #4744

Merged
merged 3 commits into from
Nov 29, 2021
Merged

KMS fixes and ISP pitch fix #4744

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b03749
dtoverlays: Drop i2c baudrate for Pi 7inch DSI screen to 50kHz
6by9 Nov 29, 2021
5d296d2
drm/vc4: Use dev_err_probe when logging error registering HDMI audio
6by9 Nov 29, 2021
ec20872
staging/bcm2835-codec: bytesperline for YUV420/YVU420 needs to be 64
6by9 Nov 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions arch/arm/boot/dts/overlays/vc4-kms-dsi-7inch-overlay.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
target = <&i2c0if>;
__overlay__ {
status = "okay";
clock-frequency = <50000>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this property be set on the reg_display node rather than here? (Asking because I don't know)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe so.

AFAIK Nothing follows the tree down to see what the highest speed supported by all the devices added to the bus can run at, so it has to be set explicitly on the host controller.

https://github.com/raspberrypi/linux/blob/rpi-5.10.y/drivers/i2c/busses/i2c-bcm2835.c#L544 reads this clock-frequency value directly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seems there's a layer of control missing from I2C - maximum permissible clock for this device.

};
};

Expand Down