drm/vc4: Add support for composite syncs to vc4_dpi #4733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hardware can combine H&V syncs onto the output enable line as composite syncs, so add the relevant configuration to do that. Signed-off-by: Dave Stevenson <[email protected]>
|
Discussion here: https://forums.raspberrypi.com/viewtopic.php?p=1942948 |
|
Yes, sorry forgot to put that link in. Whilst I haven't got anything to test csyncs with, it should be a nop for existing displays, and the new options match the firmware. We could delay merging until the person on that forum thread has tried it - I'll add a WIP tag. |
6by9
changed the title
|
I agree it's a no-op if |
6by9
changed the title
|
Confirmed as working, so WIP removed. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Nov 26, 2021
See: raspberrypi/linux#4736 kernel: vc4-kms: Rework HPD See: raspberrypi/linux#4716 kernel: drm/vc4: Add support for composite syncs to vc4_dpi See: raspberrypi/linux#4733 kernel: Pass V4L2_CID_MPEG_VIDEO_H264_MIN_QP/MAX_QP to bcm2835-v4l2-codec See: raspberrypi/linux#4705 kernel: media: i2c: ov5647: Support HFLIP and VFLIP See: raspberrypi/linux#4731 kernel: drivers: bcm2835_isp: Fix div by 0 bug See: raspberrypi/linux#4732 kernel: drivers: bcm2835_isp: Allow multiple users for the ISP driver. See: raspberrypi/linux#4709 kernel: ARM: dts: Update rpi-400 and cm4 dts to match 4-b kernel: ARM: dts: gpio-ranges property is now required See: https://forums.raspberrypi.com/viewtopic.php?t=324585 kernel: ARM: dts: bcm2711: Fix PCIe interrupts See: raspberrypi/linux#4666
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Nov 26, 2021
See: raspberrypi/linux#4736 kernel: vc4-kms: Rework HPD See: raspberrypi/linux#4716 kernel: drm/vc4: Add support for composite syncs to vc4_dpi See: raspberrypi/linux#4733 kernel: Pass V4L2_CID_MPEG_VIDEO_H264_MIN_QP/MAX_QP to bcm2835-v4l2-codec See: raspberrypi/linux#4705 kernel: media: i2c: ov5647: Support HFLIP and VFLIP See: raspberrypi/linux#4731 kernel: drivers: bcm2835_isp: Fix div by 0 bug See: raspberrypi/linux#4732 kernel: drivers: bcm2835_isp: Allow multiple users for the ISP driver. See: raspberrypi/linux#4709 kernel: ARM: dts: Update rpi-400 and cm4 dts to match 4-b kernel: ARM: dts: gpio-ranges property is now required See: https://forums.raspberrypi.com/viewtopic.php?t=324585 kernel: ARM: dts: bcm2711: Fix PCIe interrupts See: raspberrypi/linux#4666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hardware can combine H&V syncs onto the output enable line
as composite syncs, so add the relevant configuration to do that.
Signed-off-by: Dave Stevenson [email protected]