Dev/5.10/fix streamoff 1 #4599
Merged
Dev/5.10/fix streamoff 1 #4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused ctx state tracking variable and associated defines. Their presence implies they might be used, but they aren't. Signed-off-by: John Cox <[email protected]>
Before uniniting the decode context sync with the IRQ queues to ensure that decode no longer has any buffers in use. This fixes a problem that manifested as ffmpeg leaking CMA buffers when it did a stream off on OUTPUT before CAPTURE, though in reality it was probably much more dangerous than that. Signed-off-by: John Cox <[email protected]>
|
Looks ok to me. Can someone kick the tyres? |
|
Tested with kodi. Was able to play/stop hevc a number of times without issue. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Sep 23, 2021
See: raspberrypi/linux#4593 kernel: rpivid: Ensure IRQs have completed before uniniting context See: raspberrypi/linux#4599 kernel: net: phy: lan87xx: Allow more time for link detect See: raspberrypi/linux#4598
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Sep 23, 2021
See: raspberrypi/linux#4593 kernel: rpivid: Ensure IRQs have completed before uniniting context See: raspberrypi/linux#4599 kernel: net: phy: lan87xx: Allow more time for link detect See: raspberrypi/linux#4598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a CMA leak, also worked around by reordering streamoffs in FFmpeg