Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.0 #68

Merged
merged 2 commits into from
Oct 7, 2023
Merged

V3.0 #68

merged 2 commits into from
Oct 7, 2023

Conversation

rf152
Copy link
Member

@rf152 rf152 commented Oct 7, 2023

No description provided.

@rf152 rf152 merged commit b7b46e8 into main Oct 7, 2023
6 checks passed
Comment on lines +37 to +38
NDIlib_tally_t* NDI_tally;
NDIlib_send_get_tally(this->pNDI_send, NDI_tally, 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the example in the SDK, the following is correct:
NDIlib_tally_t NDI_tally;
NDIlib_send_get_tally(this->pNDI_send, &NDI_tally, 0);


char pixelStatus;
std::ofstream neopixel;

if(this->isProgram())
std::cout << "PGM: " << NDI_tally->on_program << " PVW: " << NDI_tally->on_preview << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be std::cout << "PGM: " << NDI_tally.on_program << " PVW: " << NDI_tally.on_preview << std::endl;

if(this->isProgram())
std::cout << "PGM: " << NDI_tally->on_program << " PVW: " << NDI_tally->on_preview << std::endl;

if(NDI_tally->on_program)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be if(NDI_tally.on_program)

}
else if (this->isPreview())
else if (NDI_tally->on_preview)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be else if (NDI_tally.on_preview)

@SBCV-apegram
Copy link
Contributor

I would have submitted a pull request, but my fork has other unrelated changes, and I haven't quite figured out how to cherry pick in git.

@SBCV-apegram
Copy link
Contributor

Figured it out, I submitted a pull request. I confirmed it working on my RPI 4B (don't know about the neopixel stuff, since I don't have one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants