update

rasbt · Mar 8, 2025 · 9fb2bf0 · 9fb2bf0
1 parent 92f473e
commit 9fb2bf0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/basic-tests-linux-uv.yml b/.github/workflows/basic-tests-linux-uv.yml
@@ -65,4 +65,4 @@ jobs:
         shell: bash
         run: |
           source .venv/bin/activate
-          pytest ch02/05_bpe-from-scratch test.py
+          pytest ch02/05_bpe-from-scratch/test.py
diff --git a/ch02/05_bpe-from-scratch/bpe-from-scratch.ipynb b/ch02/05_bpe-from-scratch/bpe-from-scratch.ipynb
@@ -674,9 +674,10 @@
     "        with open(vocab_path, \"w\", encoding=\"utf-8\") as file:\n",
     "            json.dump(self.vocab, file, ensure_ascii=False, indent=2)\n",
     "\n",
-    "        merges_list = [{\"pair\": list(pair), \"new_id\": new_id}\n",
-    "                       for pair, new_id in self.bpe_merges.items()]\n",
+    "        # Save BPE merges as a list of dictionaries\n",
     "        with open(bpe_merges_path, \"w\", encoding=\"utf-8\") as file:\n",
+    "            merges_list = [{\"pair\": list(pair), \"new_id\": new_id}\n",
+    "                           for pair, new_id in self.bpe_merges.items()]\n",
     "            json.dump(merges_list, file, ensure_ascii=False, indent=2)\n",
     "\n",
     "    def load_vocab_and_merges(self, vocab_path, bpe_merges_path):\n",