Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rasa test should search for test files recursively in all sub-directories, not just under tests/ #7763

Closed
koernerfelicia opened this issue Jan 20, 2021 · 4 comments · Fixed by #8151
Assignees
Labels
area:rasa-oss/cli Issues focused on the rasa command-line-interface area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. feature:ux-cli+training-data Feature: Improve user experience with Rasa CLI and training data for developers type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@koernerfelicia
Copy link
Contributor

Rasa version:
2.2.4
Python version:
3.7.2
Operating system (windows, osx, ...):
OSX

Issue:
rasa test looks recursively for files prefixed with test_, but only in subdirectories of tests/. It should look recursively in all subdirectories.
rasa test core seems to look for these files in any subdirectory.

Command or request that led to error:

rasa test
@koernerfelicia koernerfelicia added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Jan 20, 2021
@koernerfelicia
Copy link
Contributor Author

@kalkbrennerei finally got around to making this. Could you add some comments if you have any? Thank you!

from our Slack discussion:
Lu:"I think rasa test and rasa test core are both using test.py::run_core_test internally but with different args"

@kalkbrennerei
Copy link
Contributor

thanks @koernerfelicia! I think I have nothing to add 😃
but maybe I can mention this PR here. I think we decided to only accept test story files with test_ prefix, so with the fix of your issue the linked PR will become irrelevant if I'm not mistaken

@wochinge
Copy link
Contributor

wochinge commented Jan 25, 2021

I'll close my PR as well. @kalkbrennerei Do you know any specific reasons for the decisions or where we could find that? Seems like it addresses a code problem by causing friction for users.

@kalkbrennerei
Copy link
Contributor

@wochinge I think for 2.0 we wanted to enable the users to structure their projects the way they want to, so without restricting them to have a/only one tests folder. And therefore the tests must have the tests_ prefix. But it also doesn't seem ideal to me that this is causing friction to the users... This Thread seems to have a discussion about it, but not sure of the actual conclusion.

@alwx alwx added the area:rasa-oss/cli Issues focused on the rasa command-line-interface label Jan 29, 2021
@TyDunn TyDunn added the feature:ux-cli+training-data Feature: Improve user experience with Rasa CLI and training data for developers label Feb 17, 2021
@wochinge wochinge added the effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. label Mar 5, 2021
@alwx alwx self-assigned this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss/cli Issues focused on the rasa command-line-interface area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. feature:ux-cli+training-data Feature: Improve user experience with Rasa CLI and training data for developers type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants