Allow tests to be located anywhere, not just in tests directory
#8151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwx
changed the title
tests directorytests directory
alwx
commented
Mar 9, 2021
alwx
requested review from
a team,
Tawakalt and
wochinge
and removed request for
a team and
Tawakalt
wochinge
reviewed
Mar 10, 2021
| return ( | ||
| DEFAULT_E2E_TESTS_PATH in dirname | ||
| MarkdownStoryReader._is_tests_file(file_path) |
There was a problem hiding this comment.
optional: I'm a bit torn here. In my opinion this is rather animprovement than a bug and as markdown is deprecated I wouldn't change any of its behavior unless it's a bug. So in my opinion file also to just keep the old behavior here. This might also reduce the effort in case we have to do a follow-up PR for some reason in these parts.
rasa/shared/core/training_data/story_reader/markdown_story_reader.py
Outdated
Show resolved
Hide resolved
Comment on lines
354
to
356
| return Path(file_path).name.startswith(TEST_STORIES_FILE_PREFIX) or Path( | ||
| file_path | ||
| ).name.endswith("_tests.md") |
There was a problem hiding this comment.
mhm, I'd keep the old logic here (check if tests is in dirname`).
wochinge
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
rasa testshould search for test files recursively in all sub-directories, not just undertests/#7763Status (please check what you already did):
black(please check Readme for instructions)