Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webex Channel Fix: personId -> roomId #6078

Merged
merged 4 commits into from
Jul 1, 2020

Conversation

isaac-philip
Copy link
Contributor

This is a much needed fix because presently we are unable to have the rasa-bot respond back to the specific room that sends the message thus enabling no reply to the user

The fix is also presented at #5460 but since it will be released at 1.11.0 thenn we need to hotfix it soon.

References #5460

Proposed changes:

  • ...

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

This is a much needed fix because presently we are unable to have the rasa-bot respond back to the specific room that sends the message thus enabling `no reply` to the user

The fix is also presented at RasaHQ#5460 but since it will be released at 1.11.0 thenn we need to hotfix it soon.

References RasaHQ#5460
@CLAassistant
Copy link

CLAassistant commented Jun 26, 2020

CLA assistant check
All committers have signed the CLA.

@isaac-philip
Copy link
Contributor Author

@wochinge kindly help for this MR.

@sara-tagger
Copy link
Collaborator

sara-tagger commented Jun 29, 2020

Thanks for submitting a pull request 🚀 @wochinge will take a look at it as soon as possible ✨

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting this @isaac-philip 🙏
Could you please add a short changelog entry?

@wochinge wochinge removed the request for review from erohmensing June 29, 2020 07:22
@isaac-philip
Copy link
Contributor Author

Added the changelog, thanks.

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🎉

changelog/6078.bugfix.rst Outdated Show resolved Hide resolved
changelog/6078.bugfix.rst Outdated Show resolved Hide resolved
@wochinge wochinge merged commit 07da446 into RasaHQ:1.10.x Jul 1, 2020
@isaac-philip
Copy link
Contributor Author

Thanks for the help @wochinge ! 🥇

@isaac-philip
Copy link
Contributor Author

@wochinge do you have any document you can share on the release strategy employed? I would like to learn from it.

@wochinge
Copy link
Contributor

@isaac-philip Thanks for your question! We talked about your question internally, and we fully agree with you that the release process should be documented publicly and transparently. We will keep track of our progress towards this in #6260 .

Maybe this short info can help you out until #6260 is done:

  1. We release Rasa Open Source minors in fixed 4 week cycles (currently on hold as we are working towards a Rasa Open Source 2.0 major)
  2. Micro (also referred to as patch) releases are cut as required. They can only include bugfixes or documentation improvements, but no new features (following the semantic versioning guidelines)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants