Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing personId to roomId #5460

Merged
merged 3 commits into from
May 15, 2020
Merged

changing personId to roomId #5460

merged 3 commits into from
May 15, 2020

Conversation

techBeck03
Copy link
Contributor

@techBeck03 techBeck03 commented Mar 22, 2020 •
edited
Loading

Proposed changes:

  • changed personId to roomId on input channel since all of the output channel functions use roomId
  • changed roomID to roomId in custom_json output

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sara-tagger sara-tagger requested a review from TyDunn March 23, 2020 08:42
@sara-tagger
Copy link
Collaborator

sara-tagger commented Mar 23, 2020 •
edited by TyDunn
Loading

Thanks for submitting a pull request 🚀 @rgstephens will take a look at it as soon as possible ✨

@TyDunn TyDunn requested review from rgstephens and removed request for TyDunn March 23, 2020 17:41
@tmbo tmbo merged commit e0e4cfa into RasaHQ:master May 15, 2020
@isaac-philip
Copy link
Contributor

Very much needed fix, thanks!

Although what I fail to understand is why the latest package - 1.10.2 - which released few days back doesn't have this fix/code present.

Please let me know what I may be missing, thanks!

@wochinge
Copy link
Contributor

@isaac-philip This was merged into master which means it will be part of the next minor (1.11.0). Would you want to quickly backport the changes? You'd need to branch of 1.10.x, apply the changes from the PR, and then create a PR against 1.10.x.

@isaac-philip
Copy link
Contributor

isaac-philip commented Jun 17, 2020 •
edited
Loading

Thanks @wochinge for the suggestion.

I guess it would make sense to backport it since 1.11.0 is way far off.

Let me get to it.

Have a great day!

isaac-philip added a commit to isaac-philip/rasa that referenced this pull request Jun 26, 2020
@isaac-philip
Webex Channel Fix: personId -> roomId
8d3ebe9 
This is a much needed fix because presently we are unable to have the rasa-bot respond back to the specific room that sends the message thus enabling `no reply` to the user

The fix is also presented at RasaHQ#5460 but since it will be released at 1.11.0 thenn we need to hotfix it soon.

References RasaHQ#5460
@isaac-philip isaac-philip mentioned this pull request Jun 26, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgstephens rgstephens rgstephens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@techBeck03 @CLAassistant @sara-tagger @isaac-philip @wochinge @rgstephens @tmbo