-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate configs #6
Conversation
the motivation here was to support different node pools and different volumes per access/data I think this is time to refactor to have almost ALL of the parameters being specified per data/access nodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be in the form of
accessNode:
service:
type: LoadBalancer
resources:
postgresql:
databases: # only for accessNode
parameters:
persistentVolume:
dataNode:
replicas: # only for dataNode
service: # not sure if needed here
resources:
postgresql:
parameters:
persistentVolume:
accessNode: | ||
service: | ||
type: LoadBalancer | ||
|
||
# Credentials used by PostgreSQL | ||
credentials: | ||
fromValues: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I also move these to each node ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't they belong to access node only ?
if so I guess they better stay here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both access node and data node use the credentials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh
well good question
not sure then :-)
will update chart repo after final approve. |
accessNode: | ||
service: | ||
type: LoadBalancer | ||
|
||
# Credentials used by PostgreSQL | ||
credentials: | ||
fromValues: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't they belong to access node only ?
if so I guess they better stay here
charts/timescaledb-multinode/templates/statefulset-timescaledb-accessnode.yaml
Outdated
Show resolved
Hide resolved
charts/timescaledb-multinode/templates/statefulset-timescaledb-accessnode.yaml
Outdated
Show resolved
Hide resolved
charts/timescaledb-multinode/templates/statefulset-timescaledb-accessnode.yaml
Show resolved
Hide resolved
reverted affinityTemplate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
admin-guide.md
needs to be updated with all values that appear in values.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yalla good job
let's utilize in our internal PR
Added separate config for data node and access node.
Access node config according to:
https://docs.timescale.com/timescaledb/latest/how-to-guides/multi-node-setup/required-configuration/#multi-node-configuration