Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate configs #6

Merged
merged 9 commits into from
Jun 25, 2021
Merged

separate configs #6

merged 9 commits into from
Jun 25, 2021

Conversation

raresfirebolt
Copy link
Owner

Added separate config for data node and access node.

Access node config according to:
https://docs.timescale.com/timescaledb/latest/how-to-guides/multi-node-setup/required-configuration/#multi-node-configuration

@EladDolev
Copy link
Collaborator

the motivation here was to support different node pools and different volumes per access/data

I think this is time to refactor to have almost ALL of the parameters being specified per data/access nodes
can also move the postgresql params there

@raresfirebolt raresfirebolt requested a review from 123BLiN June 18, 2021 17:52
Copy link
Collaborator

@EladDolev EladDolev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be in the form of

accessNode:
  service:
    type: LoadBalancer
  resources:
  postgresql:
    databases: # only for accessNode
    parameters:
  persistentVolume:
dataNode:
  replicas: # only for dataNode
  service: # not sure if needed here
  resources:
  postgresql:
    parameters:
  persistentVolume:

charts/timescaledb-multinode/Chart.yaml Outdated Show resolved Hide resolved
accessNode:
service:
type: LoadBalancer

# Credentials used by PostgreSQL
credentials:
fromValues: true
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I also move these to each node ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't they belong to access node only ?
if so I guess they better stay here

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both access node and data node use the credentials

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh
well good question
not sure then :-)

@raresfirebolt
Copy link
Owner Author

will update chart repo after final approve.

charts/timescaledb-multinode/values.yaml Outdated Show resolved Hide resolved
charts/timescaledb-multinode/values.yaml Outdated Show resolved Hide resolved
accessNode:
service:
type: LoadBalancer

# Credentials used by PostgreSQL
credentials:
fromValues: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't they belong to access node only ?
if so I guess they better stay here

@raresfirebolt
Copy link
Owner Author

reverted affinityTemplate

Copy link
Collaborator

@EladDolev EladDolev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

admin-guide.md needs to be updated with all values that appear in values.yaml

charts/timescaledb-multinode/admin-guide.md Show resolved Hide resolved
charts/repo/index.yaml Show resolved Hide resolved
Copy link
Collaborator

@EladDolev EladDolev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yalla good job
let's utilize in our internal PR

@raresfirebolt raresfirebolt merged commit 747c09d into master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants