generate secres manually #2
Conversation
raresfirebolt
force-pushed
the
remove_secrets_from_git
branch
2 times, most recently
from
528c6e2 to
36363f3
Compare
| @@ -23,6 +23,8 @@ The following table lists the configurable parameters of the TimescaleDB Helm ch | |||
| | `image.tag` | The version of the image to pull | `pg12.5-ts2.0.0-p0` | |||
| | `image.pullPolicy` | The pull policy | `IfNotPresent` | | |||
| | `credentials.accessNode.superuser`| Password of the superuser for the Access Node | `tea` | | |||
| |`access.service.type` | Setup external access using LoadBalancer or ClusterIP | `LoadBalancer` | | |||
| | `credentials.fromValues` | Load credentials from values.yaml | `true` | | |||
There was a problem hiding this comment.
need to make this beautiful
|
|
||
| Then generate the secrets | ||
| ```console | ||
| random_password () { < /dev/urandom tr -dc _A-Z-a-z-0-9 | head -c32; } |
There was a problem hiding this comment.
this does not belong here
There was a problem hiding this comment.
Can you give more details ?
There was a problem hiding this comment.
this function is already defined above, where it is being used
you are not using it here, so why defining it again ?
| pullPolicy: IfNotPresent | ||
|
|
||
| #enable external access using LoadBalancer | ||
| access: |
There was a problem hiding this comment.
accessNode is less confusing :-)
| @@ -38,6 +38,25 @@ Alternatively, a YAML file that specifies the values for the parameters can be p | |||
| ```console | |||
| helm upgrade --install my-release -f myvalues.yaml . | |||
| ``` | |||
| ### Secret override | |||
|
|
|||
| In order to not have secrets stored in git, you can manually generate secrets for timescaledb-access endpoint and timescaledb-data endpoint. | |||
There was a problem hiding this comment.
this is not necessarily related to git
| @@ -108,6 +127,13 @@ our [TimescaleDB > Tutorial: Scaling out TimescaleDB](https://docs.timescale.com | |||
| to create distributed hypertables and start using multinode TimescaleDB. | |||
|
|
|||
| ### Connecting from another pod | |||
| If you are connecting from another pod you can disable external access completely by changing the service typpe from LoadBalancer to ClusterIP. Edit the following in values.yaml: | |||
There was a problem hiding this comment.
this should fall under ## Connecting from outside Kubernetes
There was a problem hiding this comment.
I am confused here. Isn't the purpose of ClusterIP to allow access only inside the kubernetes cluster ? Why should this be moved to ## Connecting from outside Kubernetes
There was a problem hiding this comment.
because there you say, in order of connecting from outside, 1.2.3, otherwise you can use type: ClusterIP
at any rate this is not related to ### Connecting from another pod since every service type will have here the same instructions
| @@ -38,6 +38,20 @@ Alternatively, a YAML file that specifies the values for the parameters can be p | |||
| ```console | |||
| helm upgrade --install my-release -f myvalues.yaml . | |||
| ``` | |||
| ### Secret override | |||
|
|
|||
| Instead of setting secrets in values.yaml, they can be manually generated. The following example is for timescaledb-access endpoint and timescaledb-data endpoint. | |||
There was a problem hiding this comment.
too many spaces in some places, and I think using the word endpoint might be confusing here
need to use the right terminology, or otherwise rephrasing it differently
| @@ -108,6 +122,13 @@ our [TimescaleDB > Tutorial: Scaling out TimescaleDB](https://docs.timescale.com | |||
| to create distributed hypertables and start using multinode TimescaleDB. | |||
|
|
|||
| ### Connecting from another pod | |||
| If you are connecting from another pod you can disable external access completely by changing the service type from LoadBalancer to ClusterIP. Edit the following in values.yaml: | |||
There was a problem hiding this comment.
as already stated this does not belong here, and the description should also be adapted
raresfirebolt
force-pushed
the
remove_secrets_from_git
branch
2 times, most recently
from
9366ec8 to
6c16b58
Compare
raresfirebolt
force-pushed
the
remove_secrets_from_git
branch
from
4c2057d to
329d7e3
Compare
Want to add the following improvements: