Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra labels #13

Merged
merged 10 commits into from
Jul 21, 2021
Merged

Extra labels #13

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fa13e60
Merge pull request #12 from raresfirebolt/resources_access_data_node
raresfirebolt Jul 16, 2021
63fba75
extra pod labels
raresfirebolt Jul 20, 2021
8d46f16
cleanup
raresfirebolt Jul 20, 2021
a0876fc
indentation
raresfirebolt Jul 21, 2021
0442d6b
cleanup
raresfirebolt Jul 21, 2021
d80681c
replicast to instances
raresfirebolt Jul 21, 2021
2708733
replicas
raresfirebolt Jul 21, 2021
d0f5e9a
fix inndet
raresfirebolt Jul 21, 2021
d9bbd54
new chart
raresfirebolt Jul 21, 2021
a707be2
Delete install.sh
EladDolev Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/timescaledb-multinode/templates/statefulset-timescaledb-accessnode.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
release: {{ .Release.Name }}
timescaleNodeType: access
{{ with .Values.accessNode.extraPodLabels -}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{ with .Values.accessNode.extraPodLabels -}}
{{- with .Values.accessNode.extraPodLabels }}

- should be on the left side, not on the right to reduce confusion
that's probably the reason this odd thing is working

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved the - but it's the same correct render

Also tried with but still renders correctly

       {{- if .Values.dataNode.extraPodLabels }}
       {{ toYaml .Values.dataNode.extraPodLabels }}
       {{- end }}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move - to the left

{{ toYaml . }}
{{ toYaml . }}
{{- end }}
spec:
serviceAccountName: {{ template "timescaledb.serviceAccountName" . }}
Expand Down
2 changes: 1 addition & 1 deletion charts/timescaledb-multinode/templates/statefulset-timescaledb-datanode.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
release: {{ .Release.Name }}
timescaleNodeType: data
{{ with .Values.dataNode.extraPodLabels -}}
{{ toYaml . }}
{{ toYaml . }}
{{- end }}
spec:
serviceAccountName: {{ template "timescaledb.serviceAccountName" . }}
Expand Down