Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add select all in multi select filters #551

Conversation

juliomotol
Copy link
Contributor

This PR aims to add a select all feature for multiselect filters.

Given that:

  • None is selected yet, it will select all the options.
  • Only some are selected, it will select all the options
  • All are selected, it will unselect all the options

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@fabio-ivona
Copy link
Contributor

It could be useful if this PR would include tests for this feature, in order to ensure this doesn't break in future releases 😉

@juliomotol
Copy link
Contributor Author

I don't see any component tests that I can base off of.

@rappasoft rappasoft merged commit 0242a4e into rappasoft:develop Nov 19, 2021
@rappasoft rappasoft mentioned this pull request Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants