swap inline style with tailwind-class #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changes a inline style `cursor:pointer` with the tailwind-class `cursor-pointer` applied conditionally (if `$url` is set) via the `class`-helper of the component.
rappasoft
added
the
Awaiting Next Release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be better if only Tailwind-classes are used (my CSP thinks so too).
You probably can change line 72 in
resources/views/vendor/livewire-tables/tailwind/includes/table.blade.php:with
bu since i don't use reordering, i can not test it. ✌🏼
Changes
cursor:pointerwith the tailwind-classcursor-pointerapplied conditionally (if$urlis set) via theclass-helper of the component.