Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable responsive status of the table #458

Merged
merged 4 commits into from
Sep 26, 2021
Merged

Allow to disable responsive status of the table #458

merged 4 commits into from
Sep 26, 2021

Conversation

fabio-ivona
Copy link
Contributor

@fabio-ivona fabio-ivona commented Sep 17, 2021

While developing for a new project I faced an issue while building a table with some long cell content that I wish to wrap instead of making my table to scroll:

image

My wish is to be able to disable the table responsiveness and have full control over cells class with the given methods. In tailwind setup this seems to possible to me.

So I made this PR in order to add a new property to the DataTableComponent:

class Table extends DataTableComponent
{
    use ConfirmsActions;

    public bool $responsive = false;   //<--- setting this to 'false' would disable table responsiveness

    public string $defaultSortColumn = 'created_at';
    public string $defaultSortDirection = 'desc';

    //...

Obviously the $responsive property is set to true by default, in order to avoid breaking changes

@rappasoft let me know what do you think about it!

@fabio-ivona
Copy link
Contributor Author

Merged new changes from master

@rappasoft rappasoft added the Awaiting Next Release Currently merged into development awaiting a release to master label Sep 26, 2021
@rappasoft rappasoft mentioned this pull request Sep 26, 2021
@rappasoft rappasoft merged commit a13e6a3 into rappasoft:master Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Next Release Currently merged into development awaiting a release to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants