Feature optional pagination #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed to $paginationEnabled in case we have more things to turn on/off we can use the convention. Thanks for writing tests! |
rappasoft
added
the
Awaiting Next Release
|
All of a sudden psalm doesn't like the magic properties: https://github.com/rappasoft/laravel-livewire-tables/runs/2410528328?check_suite_focus=true#step:6:8 I don't know how to get it to stop worrying about that now. Weird that it didn't before. |
|
This fixes it and should be backward compatible? We should probably steer away from the magic properties as much as we can. e0da516 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows pagination to be controlled using the $pagination property. True by default. Setting $pagination = false will disable pagination throughout.
Added tests.