Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.4.21 #1944

Merged
merged 77 commits into from
Sep 25, 2024
Merged

v3.4.21 #1944

merged 77 commits into from
Sep 25, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Sep 12, 2024

Significant change to the way that custom attributes work. Adds in some core methods for setting/getting custom attributes

There is one major change still to come which is to:

  • Add additional tests for the custom attributes.

This should help to standardise behaviour for attributes.

These will come in a subsequent release!

A short period of testing will ensue prior to this release.

Bulk Actions

Replaces internal code for setting custom attributes for some attributes:

  • BulkActionsButtonAttributes
  • BulkActionsMenuAttributes
  • BulkActionsMenuItemAttributes
  • BulkActionsThAttributes
  • BulkActionsThCheckboxAttributes
  • BulkActionsTdAttributes
  • BulkActionsTdCheckboxAttributes
    Public methods remain unchanged

Begins replacing several duplicate tests with smoother data provider based test

Columns

Generic Columns

Adds some generic column generation for the table head to allow for use of setThAttributes for these columns for:

  • Bulk Action Columns
  • Reorder Columns
    Docs updated for this

Column Labels

Adds a new method for customising Column Label Attributes
The Column itself provides the capability to style the Label shown in the "th" element. You can set custom attributes to pass to the Column Label on a per-Column basis:

For example:

Column::make('Name')
    ->setLabelAttributes(['class' => 'text-2xl'])

By default, this replaces the default classes on the label, if you would like to keep them, set the default/default-styling/default-colors flags to true as appropriate.

Blades

Adds the "default-colors" and "default-styling" ignore attributes, splits much of the default styling classes into these categories to make replacing defaults smoother.
i.e. replaces

->except('default') 

with

->except(['default','default-styling','default-colors']) 

In almost all cases (even when default-styling/default-colors are not presently used!

[v3.4.21] - 2024-09-25

Bug Fixes

New Features

Tweaks

Docs

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 30 commits August 16, 2024 07:59
* Unlock properties locked in error

---------

Co-authored-by: lrljoe <[email protected]>
* Add additional dispatch

* Add FilterApplied Event

* Add Filter Event Dispatch Tests

---------

Co-authored-by: lrljoe <[email protected]>
* Make ActionButtons An Optional Feature in Beta


---------

Co-authored-by: lrljoe <[email protected]>
* Adjust Methods - useComputedProperties

* Adjust ActionTest
* Add setIconLeft/setIconRight

* Fix styling

* Adjust Test

* Adjust ActionTest

---------

Co-authored-by: lrljoe <[email protected]>
* Adjust Action Button Icon Margin

* Adjust ChangeLog
* Change Order of "Getting Started" section

* Change to "UsersTable"
* Add a "Recommended" approach

* Add blurb to Recommended
* Add displayActionsInToolbar and actionsPosition

* Add docs and tests for setActionsInToolbar

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
lrljoe and others added 29 commits September 1, 2024 22:56
* Add Polish translation by @meavric

* Update ChangeLog to reflect translation
* Fix missing variable name

* Remove phpunit failOnWarning

* Tests

* PCOV Use Laravel 11
… as label if has a "from" property. (#1932)

* Initial Commit - Allowing Labels with "From" to be included in queries

* Fix styling

* Fixes for ButtonGroupColumn, ImageColumn, LinkColumn - to not default as label if has a "from" property.

---------

Co-authored-by: lrljoe <[email protected]>
* Migration to Core attribute management

* Fix styling

* Fix missing type hint, update tests

* Fix styling

* Remove defaults from being output

* Fix styling

* Adjust defaults

* Adjust behaviour for Bulk Actions TH

* Add "styling" to Columns docs

* Docs Adjust, add missing test

* Fix styling

* Adjust workflows - use L11 for PHPStan, use PHPUnit for L10

* Add missing test for thSortIconAttributes

* Fix styling

* Add CustomAttributesTest

* Fix styling

* Add missing tests - correct attribute to respect defaults

* Fix styling

* Remove defined processes in workflows

* Add test for setShouldBeHidden and setShouldBeDisplayed

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Merging Localisation Tweaks

* Fix styling

* Tweak localisations

* Fix styling

* Tweaks to sorting pill direction label

* Fix styling

* Fixes for Sorting Pill Labels

---------

Co-authored-by: lrljoe <[email protected]>
* Fix for Search Field Attribute Defaults

* SearchFieldAttributes -> Defaults To False
…Foundation\Auth\User to Illuminate\Contracts\Auth\Authenticatable (#1963)
* Update Pint Workflow

* Update ChangeLog

* Test Styling Workflow

* Fix styling

* Test Workflow

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe lrljoe merged commit 15e7f9b into master Sep 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants