Removing old $listeners approach (#1821)

* Removing old $listeners approach * Add comments that the events are no longer used --------- Co-authored-by: lrljoe <[email protected]>
rappasoft · Aug 4, 2024 · 8b3b223 · 8b3b223
1 parent 664e119
commit 8b3b223
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/src/DataTableComponent.php b/src/DataTableComponent.php
@@ -2,25 +2,18 @@
 
 namespace Rappasoft\LaravelLivewireTables;
 
+use Livewire\Attributes\On;
 use Livewire\Component;
 use Rappasoft\LaravelLivewireTables\Traits\HasAllTraits;
 
 abstract class DataTableComponent extends Component
 {
     use HasAllTraits;
 
-    /** @phpstan-ignore-next-line */
-    protected $listeners = [
-        'refreshDatatable' => '$refresh',
-        'setSort' => 'setSortEvent',
-        'clearSorts' => 'clearSortEvent',
-        'setFilter' => 'setFilterEvent',
-        'clearFilters' => 'clearFilterEvent',
-    ];
-
     /**
      * Runs on every request, immediately after the component is instantiated, but before any other lifecycle methods are called
      */
+    #[On('refreshDatatable')]
     public function boot(): void
     {
         //

diff --git a/src/Traits/Helpers/FilterHelpers.php b/src/Traits/Helpers/FilterHelpers.php
@@ -133,6 +133,7 @@ public function getFilterByKey(string $key)
         });
     }
 
+    #[On('setFilter')]
     #[On('set-filter')]
     public function setFilter(string $filterKey, mixed $value): void
     {
@@ -163,6 +164,7 @@ public function selectAllFilterOptions(string $filterKey): void
         $this->setFilter($filterKey, array_keys($filter->getOptions()));
     }
 
+    #[On('clearFilters')]
     #[On('clear-filters')]
     public function setFilterDefaults(): void
     {

diff --git a/src/Traits/Helpers/SortingHelpers.php b/src/Traits/Helpers/SortingHelpers.php
@@ -39,6 +39,7 @@ public function getSort(string $field): ?string
         return $this->sorts[$field] ?? null;
     }
 
+    #[On('setSort')]
     #[On('set-sort')]
     public function setSort(string $field, string $direction): string
     {
@@ -58,6 +59,7 @@ public function hasSort(string $field): bool
     /**
      * Clear the sorts array
      */
+    #[On('clearSorts')]
     #[On('clearsorts')]
     public function clearSorts(): void
     {

diff --git a/src/Traits/WithEvents.php b/src/Traits/WithEvents.php
@@ -12,21 +12,25 @@ trait WithEvents
 
     protected array $eventStatuses = ['columnSelected' => true, 'searchApplied' => false, 'filterApplied' => false];
 
+    // No Longer Used
     public function setSortEvent(string $field, string $direction): void
     {
         $this->setSort($field, $direction);
     }
 
+    // No Longer Used
     public function clearSortEvent(): void
     {
         $this->clearSorts();
     }
 
+    // No Longer Used
     public function setFilterEvent(string $filter, string $value): void
     {
         $this->setFilter($filter, $value);
     }
 
+    // No Longer Used
     public function clearFilterEvent(): void
     {
         $this->setFilterDefaults();