Fix has actions (#1901)

* Fix Action Repetitive Calling * Fix validActionsCount --------- Co-authored-by: lrljoe <[email protected]>
rappasoft · Aug 26, 2024 · 0b0d9cb · 0b0d9cb
1 parent 84eaf9b
commit 0b0d9cb
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/src/Traits/Helpers/ActionsHelpers.php b/src/Traits/Helpers/ActionsHelpers.php
@@ -29,18 +29,24 @@ public function getActionWrapperAttributes(): array
     #[Computed]
     public function hasActions(): bool
     {
-        return (new Collection($this->actions()))
-            ->filter(fn ($action) => $action instanceof Action)->count() > 0;
+        if (! isset($this->validActions)) {
+            $this->validActions = $this->getActions();
+        }
+
+        return $this->validActions->count() > 0;
     }
 
     #[Computed]
     public function getActions(): Collection
     {
-        return (new Collection($this->actions()))
-            ->filter(fn ($action) => $action instanceof Action)
-            ->each(function (Action $action, int $key) {
-                $action->setTheme($this->getTheme());
-            });
-
+        if (! isset($this->validActions)) {
+            $this->validActions = (new Collection($this->actions()))
+                ->filter(fn ($action) => $action instanceof Action)
+                ->each(function (Action $action, int $key) {
+                    $action->setTheme($this->getTheme());
+                });
+        }
+
+        return $this->validActions;
     }
 }
diff --git a/src/Traits/WithActions.php b/src/Traits/WithActions.php
@@ -2,6 +2,7 @@
 
 namespace Rappasoft\LaravelLivewireTables\Traits;
 
+use Illuminate\Support\Collection;
 use Rappasoft\LaravelLivewireTables\Traits\Configuration\ActionsConfiguration;
 use Rappasoft\LaravelLivewireTables\Traits\Helpers\ActionsHelpers;
 
@@ -16,6 +17,8 @@ trait WithActions
 
     protected string $actionsPosition = 'right';
 
+    protected ?Collection $validActions;
+
     protected function actions(): array
     {
         return [];