-
Notifications
You must be signed in to change notification settings - Fork 17
Document config options to use to enable hybridscan and increase batching in cudf exchange #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
devavret
wants to merge
4
commits into
main
Choose a base branch
from
devavret/document-batching+hyscan_configs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−0
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
73ff878
document config options to use to enable hybridscan and increase batc…
devavret c935c91
document that the configs don't work yet and need to be hardcoded
devavret f9f7dd7
correct the location of hybrid scan config. Add documentation for cud…
devavret d86e175
Update presto/docker/config/template/etc_worker/config_native.properties
devavret File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,4 +38,21 @@ cudf.exchange=false | |
| cudf.exchange.server.port=8083 | ||
| cudf.memory_resource=async | ||
|
|
||
| # Turn on to use intra-node exchange optimization. | ||
| # NOTE: In cudf exchange 20260212 branch, this is needed for UCX to use nvlink. | ||
| #cudf.intra_node_exchange=true | ||
|
|
||
| # Turn on to use rebatching to minimum of 100m rows (currently only before aggregations). | ||
| #cudf.batch_size_min_threshold=100000000 | ||
| #cudf.concat_optimization_enabled=true | ||
|
|
||
| # ================================================================================= | ||
| # NOTE: This setting is not yet propagated to the worker properly because only a fixed set of query configs are supported. | ||
| # https://github.com/prestodb/presto/blob/a62672886152c8c6b61cf301d246f217d850e357/presto-native-execution/presto_cpp/main/PrestoToVeloxQueryConfig.cpp#L106-L224 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How can I tell which configs work and which require hardcoding? Will this diff help? prestodb/presto#27164 |
||
| # As a result, this needs to be hardcoded right now. | ||
|
|
||
| # Turn on to use 100M rows per chunk for cudf partitioned output. | ||
| #cudf.partitioned_output_batch_rows=100000000 | ||
| # ================================================================================= | ||
|
|
||
| async-data-cache-enabled=false | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.