Presto: Fix for Java Automatic Memory Config (REPLACES #115)#117
Merged
Presto: Fix for Java Automatic Memory Config (REPLACES #115)#117
Conversation
simoneves
changed the title
paul-aiyedun
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous attempts at allowing automatic memory config for Java mode failed, with the Coordinator failing to start, with errors of the form...
This turns out to be because there are two additional memory-related configs that were in the Native Coordinator
config but not in the Java one which turn out to be essential, in order for the memory assignment math to be correct and not suffer from the overflow described in the error.
Thanks to @paul-aiyedun for finding the fix.
Also fixes the Java config.properties file container mapping broken accidentally in #109.