Presto: Reinstate previous JVM config for Java Worker mode#105
Closed
Presto: Reinstate previous JVM config for Java Worker mode#105
Conversation
This was referenced Oct 24, 2025
simoneves
added
the
hotfix
Contributor
Author
|
Closing as obviated by #108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #48, the Java JVM config was shared by all three variants, with generated heap size values.
On some machines (e.g. GHA Runners) these values were incompatible with the other generated memory configs, and the Coordinator container would often fail on startup, thus causing CI runs to fail because they couldn't run the Integrity Tests.
This PR splits the JVM config again so that the original 24GB values can always be used in Java Worker mode.
This in conjunction with #108 will fix the Presto Nightly CI.