Skip to content

Increase UCX upper pin to 1.19 - #352

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:branch-0.42from
pentschev:increase-ucx-upper-pin-to-1.19
Jan 22, 2025
Merged

Increase UCX upper pin to 1.19#352
rapids-bot[bot] merged 1 commit into
rapidsai:branch-0.42from
pentschev:increase-ucx-upper-pin-to-1.19

Conversation

@pentschev

Copy link
Copy Markdown
Member

Increase upper UCX pin to 1.19 to allow us supporting UCX 1.18 that is needed for RAPIDS 25.02.

@pentschev pentschev added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 22, 2025
@pentschev
pentschev requested a review from a team as a code owner January 22, 2025 18:11
@jameslamb
jameslamb requested review from jameslamb and removed request for KyleFromNVIDIA January 22, 2025 18:23

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The libucx 1.18 wheels haven't actually been published yet.

Screenshot 2025-01-22 at 12 30 02 PM

https://pypi.org/project/libucx-cu12/

The build job from rapidsai/ucx-wheels#17 is stuck waiting for CI runners: https://github.com/rapidsai/ucx-wheels/actions/runs/12914386875

We should wait to merge this until we see CI pass here and use the 1.18 wheels at runtime.

@jameslamb

Copy link
Copy Markdown
Member

I just cancelled CI here to save CI resources... will restart it once we have libucx 1.18 wheels published.

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we got UCX 1.18 in conda C++ tests:

...
  + ucx                     1.18.0  hca5d63b_0                 conda-forge            7MB
...

(build link)

and conda Python tests:

...
  + ucx               1.18.0  h53fb5aa_0                        conda-forge            7MB
...

(build link)

and wheel tests:

Successfully installed ... libucx-cu12-1.18.0 ...

(build link)

And everything passed, except jobs that are failing for unrelated conda errors!

I'll re-run that failed job once the other in-progress jobs pass here, then get this merged.

@jameslamb

Copy link
Copy Markdown
Member

/merge

@rapids-bot
rapids-bot Bot merged commit 8705534 into rapidsai:branch-0.42 Jan 22, 2025
@pentschev
pentschev deleted the increase-ucx-upper-pin-to-1.19 branch February 3, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants