Replace flake8 with ruff & cython-lint #168
Merged
+74
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbluca
added
improvement
pentschev
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
This looks great @charlesbluca , thanks for it. I left one question out of curiosity only, otherwise LGTM.
Comment on lines
+302
to
+304
| if config_dict is None: | ||
| config_dict = {} | ||
|
|
There was a problem hiding this comment.
I'm curious, is this done automatically by the linter or did you have to write manually @charlesbluca ?
There was a problem hiding this comment.
This was done manually - does this seem like a suitable alternative to the mutable default arg?
There was a problem hiding this comment.
Sure, that's in line with what we do in other places. I was primarily curious if the linter was that smart or you actually intervened manually. 🙂
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings our Python/Cython linting somewhat more in-line with that of cuDF, as well as giving us some additional Cython checks that weren't being done with flake8.