Remove support for UCX < 1.11.1 by pentschev · Pull Request #829 · rapidsai/ucx-py

pentschev · 2022-01-18T22:11:24Z

About ~1000 fewer lines of fun!

quasiben · 2022-01-18T22:13:13Z

Woot!

quasiben · 2022-01-18T22:14:43Z

We'll need @rapidsai/admins to merge due to the README changes

pentschev · 2022-01-18T22:15:03Z

Marking as draft while working on Dask-CUDA/Distributed PRs.

pentschev · 2022-01-18T22:16:15Z

We'll need @rapidsai/admins to merge due to the README changes

I think you mean @rapidsai/ops-codeowners , they only need to approve AFAIK, we can merge once they and @rapidsai/ucxpy-python-codeowners both approve then.

pentschev · 2022-01-21T16:46:19Z

rerun tests

…y-ucx-support

ajschmidt8

Approving ops-codeowner file changes

ajschmidt8 · 2022-02-22T16:04:45Z

 - pandoc=<2.0.0
 - pip
 - psutil
- libhwloc


Can this filename be updated? We don't currently support Python 3.7 any longer

If libhwloc is being removed here, can we also remove it from the integration repo below? It doesn't seem that any other RAPIDS libraries depend on it.

https://github.com/rapidsai/integration/blob/887942b09b72e081da56ca057197d1b55d5780c6/conda/recipes/rapids-build-env/meta.yaml#L91

https://github.com/search?q=org%3Arapidsai+libhwloc&type=code

Can this filename be updated? We don't currently support Python 3.7 any longer

Filename updated in 37c14fb .

If libhwloc is being removed here, can we also remove it from the integration repo below? It doesn't seem that any other RAPIDS libraries depend on it.

https://github.com/rapidsai/integration/blob/887942b09b72e081da56ca057197d1b55d5780c6/conda/recipes/rapids-build-env/meta.yaml#L91

https://github.com/search?q=org%3Arapidsai+libhwloc&type=code

Yes, it absolutely can be removed. I see a few other cases there, namely cloud-ml-examples and node, I'm not familiar with either of those repositories, but I believe the reason for them listing libhwloc was also due to the UCX-Py dependency. Should those be removed as well?

Yes, it absolutely can be removed. I see a few other cases there, namely cloud-ml-examples and node, I'm not familiar with either of those repositories, but I believe the reason for them listing libhwloc was also due to the UCX-Py dependency. Should those be removed as well?

I'm not sure if cloud-ml-examples is still maintained. I'll leave that up to you for those repos. But at the very least, we should remove it from the integration repo.

Since I don't know anything about those projects, I'll leave them as is. Filed rapidsai/integration#437 to remove libhwloc support from the integration repository.

And about another ~500 fewer lines of fun here too. Preparing for UCX-Py complete drop of UCX < 1.11.1 in rapidsai/ucx-py#829. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Mads R. B. Kristensen (https://github.com/madsbk) URL: #830

pentschev · 2022-02-22T17:08:17Z

rerun tests

jakirkham · 2022-02-22T20:38:41Z

Would be good to update these for 3.8 & 3.9 as well

ucx-py/setup.py

Line 112 in 933b373

python_requires=">=3.6",

Maybe we could change this latter one just to 3 so we don't need to keep updating it

ucx-py/setup.py

Lines 131 to 132 in 933b373

    
           "Programming Language :: Python :: 3.6", 
        
           "Programming Language :: Python :: 3.7",

Since UCX < 1.11.1 support is being dropped by UCX-Py, it doesn't require libhwloc anymore so it may be removed. UCX-Py PR removing libhwloc: rapidsai/ucx-py#829

pentschev · 2022-02-22T22:17:35Z

Would be good to update these for 3.8 & 3.9 as well

We have people using Python 3.6/3.7 still. We don't test it anymore, but it does still work and is needed by some projects so it's best to not completely block users from installing UCX-Py on older Python for now.

pentschev · 2022-02-22T22:24:54Z

Maybe we could change this latter one just to 3 so we don't need to keep updating it

Good idea as well, done in 69afa10 .

jakirkham · 2022-02-23T03:17:40Z

Would be good to update these for 3.8 & 3.9 as well

We have people using Python 3.6/3.7 still. We don't test it anymore, but it does still work and is needed by some projects so it's best to not completely block users from installing UCX-Py on older Python for now.

Interesting, who is still using UCX-Py on these older Python versions?

FWIW Python 3.6 is EOL as of 2021-12-23. So it may be worth dropping that at least.

jakirkham · 2022-02-23T03:28:07Z

Other than that LGTM

pentschev · 2022-02-23T16:31:43Z

Interesting, who is still using UCX-Py on these older Python versions?

FWIW Python 3.6 is EOL as of 2021-12-23. So it may be worth dropping that at least.

I followed up with you on that offline. Anyway, this is change is not relevant for the problem being treated in this PR, I filed #834 to do that later on.

jakirkham · 2022-02-23T22:16:48Z

@gpucibot merge

Edit: Forgot that doesn't work here 😅

jakirkham · 2022-02-23T22:17:29Z

Thanks Peter! 😄

Remove support for UCX < 1.11.1

0e2cc97

pentschev requested review from a team as code owners January 18, 2022 22:11

pentschev marked this pull request as draft January 18, 2022 22:14

pentschev mentioned this pull request Jan 18, 2022

Remove support for UCX < 1.11.1 rapidsai/dask-cuda#830

Merged

pentschev mentioned this pull request Feb 10, 2022

Remove test_ucx_config_w_env_var flaky condition dask/distributed#5765

Merged

pentschev added 2 commits February 21, 2022 02:02

Merge remote-tracking branch 'upstream/branch-0.24' into remove-legac…

5e2712e

…y-ucx-support

Merge remote-tracking branch 'upstream/branch-0.25' into remove-legac…

699a511

…y-ucx-support

ajschmidt8 approved these changes Feb 22, 2022

View reviewed changes

ajschmidt8 reviewed Feb 22, 2022

View reviewed changes

Rename builddocs file pointing to Python 3.8

37c14fb

pentschev marked this pull request as ready for review February 22, 2022 17:08

Update RTD to Python 3.8

2444a5b

jakirkham reviewed Feb 22, 2022

View reviewed changes

Comment thread .readthedocs.yml Outdated

pentschev added a commit to pentschev/integration that referenced this pull request Feb 22, 2022

Remove libhwloc

f469cd3

Since UCX < 1.11.1 support is being dropped by UCX-Py, it doesn't require libhwloc anymore so it may be removed. UCX-Py PR removing libhwloc: rapidsai/ucx-py#829

pentschev mentioned this pull request Feb 22, 2022

Remove libhwloc rapidsai/integration#437

Merged

Rename RTD conda file to be Python version agnostic

8cb2dd3

pentschev added 2 commits February 22, 2022 14:19

Fix RTD conda environment filename

8be571c

Remove minor Python versions from setup.py

69afa10

jakirkham approved these changes Feb 23, 2022

View reviewed changes

jakirkham merged commit a16f8a2 into rapidsai:branch-0.25 Feb 23, 2022

This was referenced Feb 24, 2022

Remove support for UCX < 1.11.1 dask/distributed#5859

Merged

Drop UCX < 1.11.1 on 0.25 #827

Closed

pentschev mentioned this pull request Sep 23, 2024

BlockingMode._fd_reader_callback asyncio task not end #1072

Closed

Uh oh!

Conversation

pentschev commented Jan 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quasiben commented Jan 18, 2022

Uh oh!

quasiben commented Jan 18, 2022

Uh oh!

pentschev commented Jan 18, 2022

Uh oh!

pentschev commented Jan 18, 2022

Uh oh!

pentschev commented Jan 21, 2022

Uh oh!

ajschmidt8 left a comment

Choose a reason for hiding this comment

Uh oh!

ajschmidt8 Feb 22, 2022

Choose a reason for hiding this comment

Uh oh!

pentschev Feb 22, 2022

Choose a reason for hiding this comment

Uh oh!

ajschmidt8 Feb 22, 2022

Choose a reason for hiding this comment

Uh oh!

pentschev Feb 22, 2022

Choose a reason for hiding this comment

Uh oh!

pentschev commented Feb 22, 2022

Uh oh!

jakirkham commented Feb 22, 2022

Uh oh!

Uh oh!

pentschev commented Feb 22, 2022

Uh oh!

pentschev commented Feb 22, 2022

Uh oh!

jakirkham commented Feb 23, 2022

Uh oh!

jakirkham commented Feb 23, 2022

Uh oh!

pentschev commented Feb 23, 2022

Uh oh!

jakirkham commented Feb 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakirkham commented Feb 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pentschev commented Jan 18, 2022 •

edited

Loading

jakirkham commented Feb 23, 2022 •

edited

Loading