Skip to content
This repository was archived by the owner on Sep 18, 2025. It is now read-only.

Bump isort, enable Cython package resorting - #753

Merged
ajschmidt8 merged 1 commit into
rapidsai:branch-0.21from
charlesbluca:bump-isort
Jun 24, 2021
Merged

ajschmidt8 merged 1 commit into
rapidsai:branch-0.21from
charlesbluca:bump-isort

Conversation

@charlesbluca

Copy link
Copy Markdown
Member

With rapidsai/integration#286, the version of isort running on gpuCI will be bumped to 5.6.4, allowing us to enforce the sorting of packages in Cython (pyx, pxd) files. This PR intends to:

  • Enable these checks in the gpuCI style script
  • Enable Cython package resorting in the pre-commit hook
  • Resort all the Cython files in this repo so they pass the newly enabled checks

@ajschmidt8

Copy link
Copy Markdown
Member

rerun tests

3 similar comments
@ajschmidt8

Copy link
Copy Markdown
Member

rerun tests

@madsbk

madsbk commented Jun 22, 2021

Copy link
Copy Markdown
Member

rerun tests

@madsbk

madsbk commented Jun 23, 2021

Copy link
Copy Markdown
Member

rerun tests

@charlesbluca

Copy link
Copy Markdown
Member Author

Just double checked and there aren't any changes that need to be made to the codebase on this PR - all hooks pass and this can be merged.

@galipremsagar

Copy link
Copy Markdown
Contributor

@gpucibot merge

1 similar comment
@ajschmidt8

Copy link
Copy Markdown
Member

@gpucibot merge

@ajschmidt8

Copy link
Copy Markdown
Member

@gpucibot merge

shoot. I think since this repo uses a different branch name format, it might be affecting the bot's merging capabilities. I'll have to look into this.

@ajschmidt8

Copy link
Copy Markdown
Member

oh, actually the bot isn't enabled on this repo. I'll manually merge.

@ajschmidt8
ajschmidt8 merged commit c9b4f94 into rapidsai:branch-0.21 Jun 24, 2021
@galipremsagar

Copy link
Copy Markdown
Contributor

@gpucibot merge

shoot. I think since this repo uses a different branch name format, it might be affecting the bot's merging capabilities. I'll have to look into this.

Thanks @ajschmidt8 !

@jakirkham

Copy link
Copy Markdown
Member

Thanks AJ! 😄

Yeah we are doing things manually here. It's probably not worth the effort to change that as we want to upstream this work

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants