Allow ucx-proc to be unspecified
#416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on UCX's `dlopen` behavior, it should be ok to install the GPU build on a CPU only machine. So leave `ucx-proc` unspecified and allow Conda to just pick one. This should help with our doc building issues where `ucx-proc`'s CPU build is not found.
dillon-cullinan
approved these changes
Feb 11, 2020
|
@jakirkham, is this ready to be merged? |
|
I think when @quasiben and I talked offline we concluded this might not help the underlying doc building issue. Hence why this has lingered. That said, no objections to merging if it's useful 🙂 |
|
I think we could merge this. The underlying doc build still relies on a custom built conda package which doesn't use libnuma -- we can't get libnuma installed on the RTD machines/conatiners. |
|
That's right. We have issue ( openucx/ucx#4570 ) open upstream, which would be another way to resolve this. |
|
Don't think this is still needed. So going to close it out. Though please let me know if that's not the case and can always reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on UCX's
dlopenbehavior, it should be ok to install the GPU build on a CPU only machine. So leaveucx-procunspecified and allow Conda to just pick one. This should help with our doc building issues whereucx-proc's CPU build is not found.cc @quasiben