-
Notifications
You must be signed in to change notification settings - Fork 64
split up CUDA-suffixed dependencies in dependencies.yaml #1057
Changes from all commits
f0a0c28
4c67c2c
4ecab55
40236f7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -150,10 +150,14 @@ dependencies: | |
| # post release like 1.15.0.post1 | ||
| - output_types: [requirements, pyproject] | ||
| matrices: | ||
| - matrix: {cuda: "12.*"} | ||
| - matrix: | ||
| cuda: "12.*" | ||
| cuda_suffixed: "true" | ||
| packages: | ||
| - libucx-cu12>=1.15.0,<1.15.1 | ||
| - matrix: {cuda: "11.*"} | ||
| - matrix: | ||
| cuda: "11.*" | ||
| cuda_suffixed: "true" | ||
| packages: | ||
| - libucx-cu11>=1.15.0,<1.15.1 | ||
| # this fallback is intentionally empty... it simplifies building from source | ||
|
|
@@ -173,10 +177,14 @@ dependencies: | |
| specific: | ||
| - output_types: [requirements, pyproject] | ||
| matrices: | ||
| - matrix: {cuda: "12.*"} | ||
| - matrix: | ||
| cuda: "12.*" | ||
| cuda_suffixed: "true" | ||
| packages: | ||
| - libucx-cu12>=1.15.0,<1.16 | ||
| - matrix: {cuda: "11.*"} | ||
| - matrix: | ||
| cuda: "11.*" | ||
| cuda_suffixed: "true" | ||
| packages: | ||
| - libucx-cu11>=1.15.0,<1.16 | ||
| # this fallback is intentionally empty... it simplifies building from source | ||
|
|
@@ -196,20 +204,40 @@ dependencies: | |
| - pytest-rerunfailures | ||
| - output_types: [conda] | ||
| packages: | ||
| - &cudf_conda cudf==24.8.*,>=0.0.0a0 | ||
| - &cudf_unsuffixed cudf==24.8.*,>=0.0.0a0 | ||
| - cupy>=12.0.0 | ||
| specific: | ||
| - output_types: [requirements, pyproject] | ||
| matrices: | ||
| - matrix: {cuda: "12.*"} | ||
| - matrix: | ||
| cuda: "12.*" | ||
| cuda_suffixed: "true" | ||
| packages: | ||
| - cudf-cu12==24.8.*,>=0.0.0a0 | ||
| - cupy-cuda12x>=12.0.0 | ||
| - matrix: {cuda: "11.*"} | ||
| - &cupy_cu12 cupy-cuda12x>=12.0.0 | ||
| - matrix: | ||
| cuda: "12.*" | ||
| cuda_suffixed: "false" | ||
| packages: | ||
| - *cudf_unsuffixed | ||
| # NOTE: cupy still has a "-cuda12x" suffix here, because it's suffixed | ||
| # in DLFW builds | ||
| - *cupy_cu12 | ||
| - matrix: | ||
| cuda: "11.*" | ||
| cuda_suffixed: "true" | ||
| packages: | ||
| - cudf-cu11==24.8.*,>=0.0.0a0 | ||
| - &cupy_cu11 cupy-cuda11x>=12.0.0 | ||
| - matrix: | ||
| cuda: "11.*" | ||
| cuda_suffixed: "false" | ||
| packages: | ||
| - *cudf_unsuffixed | ||
| # NOTE: cupy still has a "-cuda11x" suffix here, because it's suffixed | ||
| # in DLFW builds | ||
| - *cupy_cu11 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This matrix looks like it hasn't been updated to use fallback the way that the other repo's PR have, but is that intentional here because of the need to specify the cupy dep?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes exactly. More context: rapidsai/cugraph#4552 (comment)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you want, it might be nice to refactor this to a "depends on cudf" / "depends on cupy" structure like we have for other repos.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree, I mentioned that in that comment I linked above (rapidsai/cugraph#4552 (comment)). In the interest of time and not wanting to go through another CI cycle, I'll defer that to a follow-up PR. |
||
| - matrix: | ||
| packages: | ||
| - *cudf_conda | ||
| - *cudf_unsuffixed | ||
| - *cupy_cu11 | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this missed in an upgrade to 12.5? Feel free to slip that in here or in a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, yes. I'll put up a follow-up PR fixing this... against 24.10. There's not a functional difference for
ucx-py, since this is just a way to matrix matrices with wildcard selectors like"12.*".