Skip to content
This repository was archived by the owner on Sep 18, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ build:
# and therefore tested in this no-CUDA environment
- |
pip install \
-C rapidsai.matrix-entry="cuda=12.2" \
-C rapidsai.matrix-entry="cuda=12.2;cuda_suffixed=true" \
Copy link
Copy Markdown
Contributor

@bdice bdice Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this missed in an upgrade to 12.5? Feel free to slip that in here or in a follow-up PR.

Suggested change
-C rapidsai.matrix-entry="cuda=12.2;cuda_suffixed=true" \
-C rapidsai.matrix-entry="cuda=12.5;cuda_suffixed=true" \

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, yes. I'll put up a follow-up PR fixing this... against 24.10. There's not a functional difference for ucx-py, since this is just a way to matrix matrices with wildcard selectors like "12.*".

.

conda:
Expand Down
7 changes: 4 additions & 3 deletions ci/release/update-version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,11 @@ function sed_runner() {
DEPENDENCIES=(
cudf
)
for FILE in dependencies.yaml; do
for DEP in "${DEPENDENCIES[@]}"; do
sed_runner "/-.* ${DEP}\(-cu[[:digit:]]\{2\}\)\{0,1\}==/ s/==.*/==${NEXT_RAPIDS_SHORT_TAG_PEP440}.*,>=0.0.0a0/g" "${FILE}"
for DEP in "${DEPENDENCIES[@]}"; do
for FILE in dependencies.yaml conda/environments/*.yml; do
sed_runner "/-.* ${DEP}\(-cu[[:digit:]]\{2\}\)\{0,1\}==/ s/==.*/==${NEXT_SHORT_TAG_PEP440}.*,>=0.0.0a0/g" "${FILE}"
done
sed_runner "/\"${DEP}==/ s/==.*\"/==${NEXT_SHORT_TAG_PEP440}.*,>=0.0.0a0\"/g" pyproject.toml
done

for FILE in .github/workflows/*.yaml; do
Expand Down
46 changes: 37 additions & 9 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,14 @@ dependencies:
# post release like 1.15.0.post1
- output_types: [requirements, pyproject]
matrices:
- matrix: {cuda: "12.*"}
- matrix:
cuda: "12.*"
cuda_suffixed: "true"
packages:
- libucx-cu12>=1.15.0,<1.15.1
- matrix: {cuda: "11.*"}
- matrix:
cuda: "11.*"
cuda_suffixed: "true"
packages:
- libucx-cu11>=1.15.0,<1.15.1
# this fallback is intentionally empty... it simplifies building from source
Expand All @@ -173,10 +177,14 @@ dependencies:
specific:
- output_types: [requirements, pyproject]
matrices:
- matrix: {cuda: "12.*"}
- matrix:
cuda: "12.*"
cuda_suffixed: "true"
packages:
- libucx-cu12>=1.15.0,<1.16
- matrix: {cuda: "11.*"}
- matrix:
cuda: "11.*"
cuda_suffixed: "true"
packages:
- libucx-cu11>=1.15.0,<1.16
# this fallback is intentionally empty... it simplifies building from source
Expand All @@ -196,20 +204,40 @@ dependencies:
- pytest-rerunfailures
- output_types: [conda]
packages:
- &cudf_conda cudf==24.8.*,>=0.0.0a0
- &cudf_unsuffixed cudf==24.8.*,>=0.0.0a0
- cupy>=12.0.0
specific:
- output_types: [requirements, pyproject]
matrices:
- matrix: {cuda: "12.*"}
- matrix:
cuda: "12.*"
cuda_suffixed: "true"
packages:
- cudf-cu12==24.8.*,>=0.0.0a0
- cupy-cuda12x>=12.0.0
- matrix: {cuda: "11.*"}
- &cupy_cu12 cupy-cuda12x>=12.0.0
- matrix:
cuda: "12.*"
cuda_suffixed: "false"
packages:
- *cudf_unsuffixed
# NOTE: cupy still has a "-cuda12x" suffix here, because it's suffixed
# in DLFW builds
- *cupy_cu12
- matrix:
cuda: "11.*"
cuda_suffixed: "true"
packages:
- cudf-cu11==24.8.*,>=0.0.0a0
- &cupy_cu11 cupy-cuda11x>=12.0.0
- matrix:
cuda: "11.*"
cuda_suffixed: "false"
packages:
- *cudf_unsuffixed
# NOTE: cupy still has a "-cuda11x" suffix here, because it's suffixed
# in DLFW builds
- *cupy_cu11
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matrix looks like it hasn't been updated to use fallback the way that the other repo's PR have, but is that intentional here because of the need to specify the cupy dep?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes exactly. More context: rapidsai/cugraph#4552 (comment)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, it might be nice to refactor this to a "depends on cudf" / "depends on cupy" structure like we have for other repos.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I mentioned that in that comment I linked above (rapidsai/cugraph#4552 (comment)).

In the interest of time and not wanting to go through another CI cycle, I'll defer that to a follow-up PR.

- matrix:
packages:
- *cudf_conda
- *cudf_unsuffixed
- *cupy_cu11
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ commit-files = [
# (this is overridden in wheel publishing)
disable-cuda=true
dependencies-file = "dependencies.yaml"
matrix-entry = "cuda_suffixed=true"
requires = [
"cython>=3.0.0",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit dependencies.yaml and run `rapids-dependency-file-generator`.
Expand Down