compute-build-details: switch to just producing the datetime - #608
Merged
Conversation
jameslamb
added
improvement
This was referenced Jul 31, 2026
Merged
jameslamb
changed the title
jameslamb
marked this pull request as ready for review
July 31, 2026 18:12
bdice
approved these changes
Jul 31, 2026
rapids-bot Bot
pushed a commit
to rapidsai/gha-tools
that referenced
this pull request
Jul 31, 2026
…on (#269) Contributes to rapidsai/build-planning#218 Complements rapidsai/shared-workflows#608 For conda builds, RAPIDS projects run `source rapids-date-string` and then thread the environment variable it sets (`RAPIDS_DATE_STRING`) through into conda package build strings, like this: ```shell source rapids-date-string ``` ([rapidsai/cuml - ci/build_cpp.sh](https://github.com/rapidsai/cuml/blob/74f5ffae8f72ca38618b55d84ad234067abd64c1/ci/build_cpp.sh#L8)) ```yaml context: ... date_string: '${{ env.get("RAPIDS_DATE_STRING") }}' ... ... outputs: - package: name: libcuml version: ${{ version }} ... string: cuda${{ cuda_major }}_${{ date_string }}_${{ head_rev }} ``` ([rapidsai/cuml - conda/recipes/libcuml/recipe.yaml](https://github.com/rapidsai/cuml/blob/74f5ffae8f72ca38618b55d84ad234067abd64c1/conda/recipes/libcuml/recipe.yaml#L100)) In rapidsai/build-planning#218 we're moving from `YYMMDD` date components to `YYMMDDhhmmss`, and prefer to have a different variable name (`RAPIDS_DATETIME_STRING`) ... this introduces a new `rapids-datetime-string` for that purpose. ## Notes for Reviewers ### We can remove `rapids-date-string` soon From GitHub searches, it seems to me that `rapids-date-string` and environment variable `RAPIDS_DATE_STRING` are only used in CI builds of RAPIDS conda packages. Once all repos are switched over to `rapids-datetime-string` / `RAPIDS_DATETIME_STRING`, we could remove `rapids-date-string`. Nice side benefit... that'll cut out some GitHub API calls from our CI, because builds we'll no longer execute this on every run of a `ci/build_{cpp,python}.sh` script: https://github.com/rapidsai/gha-tools/blob/02ea00f8c3b257c8aeb94cb757724932e70ce0e2/tools/rapids-date-string#L5-L8 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #269
Member
Author
|
This is backwards-compatible (just modifies a not-used-anywhere workflow + an optional input to other workflows), so it should be safe to merge. Merging so other PRs for rapidsai/build-planning#218 can target |
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#603 added a
compute-build-detailsworkflow, to generate a stable version component for nightly packages.This adjusts that based on feedback in rapidsai/cugraph-gnn#508 (comment) that we'd prefer to handle conda packages and wheels differently.
Notes for Reviewers
How I tested this
See "How I tested this" in rapidsai/cugraph-gnn#508