Skip to content

remove git clones and telemetry for package-publishing jobs, use full semver tags for third-party actions #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
Jun 29, 2026
Merged

remove git clones and telemetry for package-publishing jobs, use full semver tags for third-party actions #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37a7073
use shallow checkout for wheels-publish, use full semver tags for thi…
jameslamb Jun 29, 2026
fcf282d
remove cloning and telemetry completely
jameslamb Jun 29, 2026
6e08fda
fall back to github.sha
jameslamb Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-devcontainer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
tag: ${{ steps.build.outputs.tag }}
version: ${{ steps.setup.outputs.version }}
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
fetch-depth: 0
persist-credentials: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-in-devcontainer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:
runs-on: "linux-${{ matrix.ARCH }}-${{ inputs.node_type }}"
name: "${{ matrix.ARCH }}, ${{ matrix.CUDA_VER }}, ${{ matrix.PACKAGER }}"
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
repository: ${{ inputs.repo }}
ref: ${{ inputs.sha }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/changed-files.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
- name: Checkout code repo
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: true
- name: Calculate changed files
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
RAPIDS_GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
steps:
- name: Checkout code
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: true
- name: Telemetry setup
Expand Down Expand Up @@ -97,7 +97,7 @@ jobs:
VERSION_FILES_CHANGED: ${{ (inputs.enable_check_version_files_changed && fromJSON(steps.changed-files.outputs.changed_file_groups).version_files) || 'false' }}
- name: Fetch tags
if: ${{ inputs.enable_check_version_against_tag }}
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: false
fetch-depth: 0 # https://github.com/actions/checkout/issues/1471
Expand Down Expand Up @@ -126,7 +126,7 @@ jobs:
image: rapidsai/ci-conda:26.08-cuda13.3.0-ubuntu24.04-py3.12 # zizmor: ignore[unpinned-images]
steps:
- name: Checkout code
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
fetch-depth: 0
persist-credentials: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conda-cpp-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ jobs:
role-to-assume: ${{ vars.AWS_ROLE_ARN }}
aws-region: ${{ vars.AWS_REGION }}
role-duration-seconds: 43200 # 12h
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
repository: ${{ inputs.repo }}
ref: ${{ inputs.sha }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/conda-cpp-post-build-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
role-to-assume: ${{ vars.AWS_ROLE_ARN }}
aws-region: ${{ vars.AWS_REGION }}
role-duration-seconds: 43200 # 12h
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
repository: ${{ inputs.repo }}
ref: ${{ inputs.sha }}
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
EXTRACTED_DIR=$(rapids-extract-conda-files "${CPP_DIR}")
echo "RAPIDS_EXTRACTED_DIR=${EXTRACTED_DIR}" >> "${GITHUB_ENV}"
- name: Get weak detection tool
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
repository: rapidsai/detect-weak-linking
ref: refs/heads/main
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conda-cpp-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
role-duration-seconds: 43200 # 12h

- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
repository: ${{ inputs.repo }}
ref: ${{ inputs.sha }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conda-python-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:
role-to-assume: ${{ vars.AWS_ROLE_ARN }}
aws-region: ${{ vars.AWS_REGION }}
role-duration-seconds: 43200 # 12h
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
repository: ${{ inputs.repo }}
ref: ${{ inputs.sha }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conda-python-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
role-duration-seconds: 43200 # 12h

- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
repository: ${{ inputs.repo }}
ref: ${{ inputs.sha }}
Expand Down
22 changes: 3 additions & 19 deletions .github/workflows/conda-upload-packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,18 +71,6 @@ jobs:
env:
RAPIDS_BUILD_TYPE: ${{ inputs.build_type }}
steps:
- name: Telemetry setup
uses: rapidsai/shared-actions/telemetry-dispatch-setup@main
continue-on-error: true
if: ${{ vars.TELEMETRY_ENABLED == 'true' }}
env:
GH_TOKEN: ${{ github.token }}
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
with:
repository: ${{ inputs.repo }}
ref: ${{ inputs.sha }}
fetch-depth: 0
persist-credentials: true

- name: Standardize repository information
uses: rapidsai/shared-actions/rapids-github-info@main
Expand All @@ -91,7 +79,9 @@ jobs:
branch: ${{ inputs.branch }}
build_workflow_name: ${{ inputs.build_workflow_name }}
date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
# On 'push' or 'tag', 'inputs.sha' is null.
# Fall back to 'github.sha' to avoid needing a repo checkout.
sha: ${{ inputs.sha || github.sha }}

# Per the docs at https://docs.github.com/en/rest/rate-limit/rate-limit?apiVersion=2022-11-28#get-rate-limit-status-for-the-authenticated-user,
# checking '/rate_limit | jq .' should not itself count against any rate limits.
Expand All @@ -117,9 +107,3 @@ jobs:
SKIP_UPLOAD_PKGS: ${{ inputs.skip_upload_pkgs }}
RAPIDS_CONDA_UPLOAD_LABEL: ${{ inputs.upload_to_label }}
GH_TOKEN: ${{ github.token }}
- name: Telemetry upload attributes
uses: rapidsai/shared-actions/telemetry-dispatch-stash-job-artifacts@main
continue-on-error: true
if: ${{ vars.TELEMETRY_ENABLED == 'true' }}
env:
GH_TOKEN: ${{ github.token }}
4 changes: 2 additions & 2 deletions .github/workflows/custom-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ jobs:
role-to-assume: ${{ vars.AWS_ROLE_ARN }}
aws-region: ${{ vars.AWS_REGION }}
role-duration-seconds: 43200 # 12h
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
repository: ${{ inputs.repo }}
ref: ${{ inputs.sha }}
Expand Down Expand Up @@ -192,7 +192,7 @@ jobs:
GH_TOKEN: ${{ inputs.alternative-gh-token-secret-name && secrets[inputs.alternative-gh-token-secret-name] || github.token }} # zizmor: ignore[overprovisioned-secrets]
- name: Get RAPIDS License Builder
if: ${{ inputs.requires_license_builder }}
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
repository: "rapidsai/spdx-license-builder"
ref: "refs/heads/main"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-builder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
NEEDS: ${{ inputs.needs }}
run: jq -en 'env.NEEDS | fromjson | all(.result as $result | ["success", "skipped"] | any($result == .))'
- name: Checkout code
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
fetch-depth: 1
persist-credentials: false
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/wheels-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,11 @@ jobs:
role-duration-seconds: 43200 # 12h

- name: checkout code repo
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
repository: ${{ inputs.repo }}
ref: ${{ inputs.sha }}
fetch-depth: 0 # unshallow fetch for setuptools-scm
fetch-depth: 0
persist-credentials: false

- name: Standardize repository information
Expand All @@ -175,7 +175,7 @@ jobs:
echo "EXTRA_REPO_PATH=${EXTRA_REPO_PATH}" >> "${GITHUB_OUTPUT}"

- name: checkout extra repos
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
if: ${{ inputs.extra-repo != '' }}
with:
repository: ${{ inputs.extra-repo }}
Expand Down
24 changes: 3 additions & 21 deletions .github/workflows/wheels-publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,20 +83,6 @@ jobs:
env:
RAPIDS_BUILD_TYPE: ${{ inputs.build_type }}
steps:
- name: checkout code repo
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
with:
repository: ${{ inputs.repo }}
ref: ${{ inputs.sha }}
fetch-depth: 0 # unshallow fetch for setuptools-scm
persist-credentials: false

- name: Telemetry setup
uses: rapidsai/shared-actions/telemetry-dispatch-setup@main
continue-on-error: true
if: ${{ vars.TELEMETRY_ENABLED == 'true' }}
env:
GH_TOKEN: ${{ github.token }}

- name: Standardize repository information
uses: rapidsai/shared-actions/rapids-github-info@main
Expand All @@ -105,7 +91,9 @@ jobs:
branch: ${{ inputs.branch }}
build_workflow_name: ${{ inputs.build_workflow_name }}
date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
# On 'push' or 'tag', 'inputs.sha' is null.
# Fall back to 'github.sha' to avoid needing a repo checkout.
sha: ${{ inputs.sha || github.sha }}

@jameslamb jameslamb Jun 29, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first build of that test RMM PR failed like this:

RAPIDS_REPOSITORY=rapidsai/rmm
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
Error: Process completed with exit code 128.

(build link)

If the sha input to rapidsai/shared-actions/rapids-github-info is null or an empty string, it falls back to running git rev-parse HEAD.

https://github.com/rapidsai/shared-actions/blob/113b75588021524a58ebbd8c4b91fb46eb464a0c/rapids-github-info/action.yml#L34-L36

It'll be null when this workflow is triggered by push (merge to main) or tag.

In those cases, I think it's safe and appropriate to fall back to github.sha if inputs.sha is not provided. Based on my read of https://docs.github.com/en/actions/reference/workflows-and-actions/contexts, that should be the value we want in push or tag contexts.

I restarted rmm CI, let's see what it says: https://github.com/rapidsai/rmm/actions/runs/28388699537

@jameslamb jameslamb Jun 29, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That worked!

And looks to me like the correct SHA and versions were chosen

Image

https://github.com/rapidsai/rmm/commits/main/

conda:

Image

wheels:

Image

https://github.com/rapidsai/rmm/actions/runs/28388699537


# Per the docs at https://docs.github.com/en/rest/rate-limit/rate-limit?apiVersion=2022-11-28#get-rate-limit-status-for-the-authenticated-user,
# checking '/rate_limit | jq .' should not itself count against any rate limits.
Expand Down Expand Up @@ -157,9 +145,3 @@ jobs:
env:
UPLOAD_DIR: ${{ steps.download_wheels.outputs.package_upload_dir }}
TWINE_PASSWORD: ${{ secrets.RAPIDSAI_PYPI_TOKEN }}
- name: Telemetry upload attributes
uses: rapidsai/shared-actions/telemetry-dispatch-stash-job-artifacts@main
continue-on-error: true
if: ${{ vars.TELEMETRY_ENABLED == 'true' }}
env:
GH_TOKEN: ${{ github.token }}
4 changes: 2 additions & 2 deletions .github/workflows/wheels-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,11 +180,11 @@ jobs:
run: nvidia-smi

- name: checkout code repo
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
repository: ${{ inputs.repo }}
ref: ${{ inputs.sha }}
fetch-depth: 0 # unshallow fetch for setuptools-scm
fetch-depth: 0
persist-credentials: false

- name: Telemetry setup
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ repos:
- id: codespell
additional_dependencies: [tomli]
- repo: https://github.com/rapidsai/pre-commit-hooks
rev: v1.5.1
rev: v1.6.0
hooks:
- id: verify-copyright
- repo: https://github.com/zizmorcore/zizmor-pre-commit
Expand Down