Skip to content

Bump isort, enable Cython package resorting #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
Jun 24, 2021
Merged

Bump isort, enable Cython package resorting #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
725101c
Bump isort, enable Cython package resorting
charlesbluca Jun 14, 2021
e157815
Add settings path arg to gpuCI check
charlesbluca Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
repos:
- repo: https://github.com/timothycrosley/isort
rev: 5.0.7
- repo: https://github.com/pycqa/isort
rev: 5.6.4
hooks:
- id: isort
args: ["--settings-path=python/setup.cfg"]
files: python/.*
exclude: __init__.py$
types: [text]
types_or: [python, cython]
- repo: https://github.com/ambv/black
rev: 19.10b0
hooks:
Expand Down
2 changes: 1 addition & 1 deletion ci/checks/style.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ LANG=C.UTF-8
conda activate rapids

# Run isort and get results/return code
ISORT=`isort --recursive --check-only python`
ISORT=`isort --check-only python --settings-path=python/setup.cfg `
ISORT_RETVAL=$?

# Run black and get results/return code
Expand Down